build: auto start Jenkins CI via PR labels #34089

mmarchini · 2020-06-27T19:48:53Z

Add an Action that will find every PR with the request-ci label and
will start a Jenkins CI for each of these Pull Requests. The scheduler
event is used to circumvent GitHub Actions limitations on Pull Requests
from forks (where secrets are not accessible and the GITHUB_TOKEN is
read-only).

If the Action fails to start a CI, it will add a request-ci-failed
label and will leave a comment with the error message from NCU.

Requirements to land

Create a Jenkins token for @nodejs-github-bot
Add JENKINS_USER and JENKINS_TOKEN secrets to this repository (or to the entire org, if we want this to work on forks such as quic and node-auto-test as well)
Land ncu-ci: command to start CI for PRs node-core-utils#445 and wait for the next NCU release
Test more extensively on node-auto-test before landing
Create request-ci and request-ci-failed labels in this repository

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

mmarchini · 2020-06-27T19:49:49Z

.github/workflows/auto-start-ci.yml

+          ncu-config set username ${{ secrets.JENKINS_USER }}
+          ncu-config set token none
+          ncu-config set jenkins_token ${{ secrets.JENKINS_TOKEN }}
+          ncu-config set owner ${{ env.OWNER }}
+          ncu-config set repo ${{ env.REPOSITORY }}


We probably should provide a way to set ncu configs via environment variables, so we don't have to worry about writing to disk here.

mmarchini · 2020-06-27T20:07:33Z

.github/workflows/auto-start-ci.yml

+          query: |
+            query prs($owner:String!, $repo:String!) {
+              repository(owner:$owner, name:$repo) {
+                pullRequests(labels: ["request-ci"], states: OPEN, last: 100) {


If we're worried about the number of concurrent Jenkins jobs running, we could reduce this to 5 and increase the scheduler to 15-30 minutes.

mscdex · 2020-06-27T20:11:51Z

If we add something like this, shouldn't we just get rid of the "CERTIFY_SAFE" checkbox in CI then, since there is no way to make such a confirmation explicit when applying the new label to a PR?

mmarchini · 2020-06-27T20:18:32Z

That's a good question. We could consider that adding the label means the collaborator is certifying that this PR is safe (same could be said about starting a CI though)

mmarchini · 2020-06-27T20:20:50Z

We could also have two labels, but that seems unnecessary

.github/workflows/auto-start-ci.yml

Trott · 2020-06-28T15:19:58Z

@nodejs/build

mmarchini · 2020-06-28T20:06:07Z

Not sure who I should ping to get consensus on adding the secrets to the repo (or if I need to do it) and to create the labels. @nodejs/tsc maybe?

Also don't know who has access to the github-bot account to create a Jenkins token for it.

cclauss

RSLGTM Impressive work!

mmarchini · 2020-07-30T05:50:31Z

Ok, figured out the github-bot bits, will create the tokens on the repository before landing it.

Removed the blocked label, but it would be good to have some more reviews (especially on the general approach), I intend to land on friday or saturday to give folks a bit more time to review. I also ask to let me land it since there are other tasks that need to be accomplished while landing (create labels, add secrets to the repo)

(I'd like to land this before the commit queue since both use a similar approach, but this action won't make changes to our main branch)

.github/workflows/auto-start-ci.yml

phillipj

Really nice work 👍

mmarchini · 2020-07-31T00:51:59Z

@nodejs/build @nodejs/tsc any other reviews/comments/suggestions/objections before I land this tomorrow? (I thought about pinging collaborators but that might be too much :) )

Add an Action that will find every PR with the `request-ci` label and will start a Jenkins CI for each of these Pull Requests. The scheduler event is used to circumvent GitHub Actions limitations on Pull Requests from forks (where secrets are not accessible and the GITHUB_TOKEN is read-only). If the Action fails to start a CI, it will add a `request-ci-failed` label and will leave a comment with the error message from NCU. Fixes: nodejs/github-bot#234

mmarchini · 2020-07-31T22:29:36Z

Labels created:

Add an Action that will find every PR with the `request-ci` label and will start a Jenkins CI for each of these Pull Requests. The scheduler event is used to circumvent GitHub Actions limitations on Pull Requests from forks (where secrets are not accessible and the GITHUB_TOKEN is read-only). If the Action fails to start a CI, it will add a `request-ci-failed` label and will leave a comment with the error message from NCU. Fixes: nodejs/github-bot#234 PR-URL: #34089 Reviewed-By: Christian Clauss <cclauss@me.com>

mmarchini · 2020-07-31T23:11:34Z

Landed in 6cab3b0

Add an Action that will find every PR with the `request-ci` label and will start a Jenkins CI for each of these Pull Requests. The scheduler event is used to circumvent GitHub Actions limitations on Pull Requests from forks (where secrets are not accessible and the GITHUB_TOKEN is read-only). If the Action fails to start a CI, it will add a `request-ci-failed` label and will leave a comment with the error message from NCU. Fixes: nodejs/github-bot#234 PR-URL: #34089 Reviewed-By: Christian Clauss <cclauss@me.com>

mmarchini added the blocked PRs that are blocked by other issues or PRs. label Jun 27, 2020

nodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Jun 27, 2020

mmarchini commented Jun 27, 2020

View reviewed changes

himself65 reviewed Jun 28, 2020

View reviewed changes

.github/workflows/auto-start-ci.yml Outdated Show resolved Hide resolved

mmarchini mentioned this pull request Jul 1, 2020

Request permission to create personal and Jenkins tokens for github-bot add Secrets to nodejs/reliability and nodejs/node nodejs/admin#523

Closed

This was referenced Jul 25, 2020

Increase privilege of github-bot on Jenkins nodejs/build#2394

Closed

Add @nodejs-github-bot to @nodejs/collaborators nodejs/admin#536

Closed

Node.js Technical Steering Committee (TSC) Meeting 2020-07-30 nodejs/TSC#896

Closed

cclauss approved these changes Jul 30, 2020

View reviewed changes

mmarchini force-pushed the auto-start-ci-via-label branch from f1c9444 to a1121fa Compare July 30, 2020 05:41

mmarchini self-assigned this Jul 30, 2020

mmarchini removed the blocked PRs that are blocked by other issues or PRs. label Jul 30, 2020

phillipj reviewed Jul 30, 2020

View reviewed changes

.github/workflows/auto-start-ci.yml Outdated Show resolved Hide resolved

phillipj approved these changes Jul 30, 2020

View reviewed changes

phillipj mentioned this pull request Jul 30, 2020

bot no longer autostarts CI? nodejs/github-bot#235

Closed

mmarchini force-pushed the auto-start-ci-via-label branch from a1121fa to 9a4ae9c Compare July 30, 2020 23:07

mmarchini force-pushed the auto-start-ci-via-label branch from 9a4ae9c to 84de5d9 Compare July 31, 2020 22:24

mmarchini closed this Jul 31, 2020

codebytere mentioned this pull request Aug 10, 2020

v14.8.0 proposal #34704

Merged

lundibundi mentioned this pull request Aug 23, 2020

PSA: it's now possible to start Jenkins CI by adding request-ci label to PRs #34594

Closed

codebytere mentioned this pull request Sep 28, 2020

v12.19.0 proposal #35401

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: auto start Jenkins CI via PR labels #34089

build: auto start Jenkins CI via PR labels #34089

mmarchini commented Jun 27, 2020 •

edited

Loading

mmarchini Jun 27, 2020

mmarchini Jun 27, 2020

mscdex commented Jun 27, 2020

mmarchini commented Jun 27, 2020

mmarchini commented Jun 27, 2020

Trott commented Jun 28, 2020

mmarchini commented Jun 28, 2020 •

edited

Loading

cclauss left a comment

mmarchini commented Jul 30, 2020

phillipj left a comment

mmarchini commented Jul 31, 2020 •

edited

Loading

mmarchini commented Jul 31, 2020

mmarchini commented Jul 31, 2020

build: auto start Jenkins CI via PR labels #34089

build: auto start Jenkins CI via PR labels #34089

Conversation

mmarchini commented Jun 27, 2020 • edited Loading

Requirements to land

Checklist

mmarchini Jun 27, 2020

Choose a reason for hiding this comment

mmarchini Jun 27, 2020

Choose a reason for hiding this comment

mscdex commented Jun 27, 2020

mmarchini commented Jun 27, 2020

mmarchini commented Jun 27, 2020

Trott commented Jun 28, 2020

mmarchini commented Jun 28, 2020 • edited Loading

cclauss left a comment

Choose a reason for hiding this comment

mmarchini commented Jul 30, 2020

phillipj left a comment

Choose a reason for hiding this comment

mmarchini commented Jul 31, 2020 • edited Loading

mmarchini commented Jul 31, 2020

mmarchini commented Jul 31, 2020

mmarchini commented Jun 27, 2020 •

edited

Loading

mmarchini commented Jun 28, 2020 •

edited

Loading

mmarchini commented Jul 31, 2020 •

edited

Loading