test: fix flaky test-fs-stream-construct #34203

Trott · 2020-07-04T16:40:10Z

The test is marked flaky on ARM because it times out on Raspberry Pi
devices in CI. Split the single test file into four separate test files
to avoid timing out.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

Trott · 2020-07-04T22:59:40Z

I tried using debuglog('test') to figure out what is going on with this test, but it looks like maybe NODE_DEBUG=test is not set up on the Raspberry Pi devices in CI?

Trott · 2020-07-04T23:02:25Z

Here's what I'm seeing with console.log and some date stamps:

15:58:04   duration_ms: 240.89
15:58:04   severity: fail
15:58:04   exitcode: -15
15:58:04   stack: |-
15:58:04     timeout
15:58:04     7/4/2020, 10:54:05 PM start test
15:58:04     7/4/2020, 10:54:05 PM waiting for callbacks
15:58:04     7/4/2020, 10:54:05 PM fs open() callback
15:58:04     7/4/2020, 10:54:05 PM WriteStream constructor
15:58:04     7/4/2020, 10:54:05 PM WriteStream open() callback
15:58:04     7/4/2020, 10:54:05 PM inner fs open() callback
15:58:04     7/4/2020, 10:54:05 PM error event callback
15:58:04     7/4/2020, 10:54:06 PM close event callback
15:58:04   ...

So the write-error test runs completely but then doesn't exit and times out 4 minutes later.

Source code for the test as it stands now with those console.log statements: https://github.com/nodejs/node/blob/ae1e6e323ded98796c43f46cdcd8cd1312152840/test/parallel/test-fs-stream-construct-compat-error-write.js

/ping @ronag Any idea what might be going wrong on Raspberry Pi only apparently?

ronag · 2020-07-05T00:21:21Z

That seems rather weird. timeout means that it is still stuck in the event loop? What is it waiting for?

Trott · 2020-07-05T00:37:39Z

That seems rather weird. timeout means that it is still stuck in the event loop? What is it waiting for?

Yes, it would seem to be stuck in the event loop, and I don't know what it's waiting for.... Guess I can add more debug statements and/or try some different things (like explicitly closing files).

ronag · 2020-07-05T07:00:25Z

Explicitly closing the files sounds like a good idea. Though, I wonder if there is a deeper bug here somewhere? I'm not sure at what level this kind of thing lives at. libuv?

Trott · 2020-07-05T13:40:25Z

Explicitly closing the files sounds like a good idea. Though, I wonder if there is a deeper bug here somewhere? I'm not sure at what level this kind of thing lives at. libuv?

The fact that it works everywhere else seems to suggest a bug, although it could have something to do with the tmp dir on these machines being...I forget...a symlink? NFS-mounted? Both?

nodejs-github-bot · 2020-07-05T13:41:53Z

CI: https://ci.nodejs.org/job/node-test-pull-request/32220/

ronag · 2020-07-05T13:45:43Z

a symlink? NFS-mounted? Both?

Might explain the difference. Though, it would still be a bug, no?

nodejs-github-bot · 2020-07-05T18:19:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/32222/

ronag · 2020-07-05T18:21:06Z

test/parallel/test-fs-stream-construct-compat-error-write.js

@@ -31,7 +31,7 @@ tmpdir.refresh();
    });
  });

-  fs.open(`${tmpdir.path}/dummy`, 'wx+', common.mustCall((err) => {
+  fs.open(`${tmpdir.path}/dummy`, 'wx+', common.mustCall((err, fd) => {
    debuglog('fs open() callback');
    assert.ifError(err);


I think you want the close here, before creating the write stream

FWIW, putting it where I put it causes the test to pass, so it's definitely that open fd that's keeping the event loop open. I'll move it here and run again.

nodejs-github-bot · 2020-07-05T18:35:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/32223/ ✅

ERR_FEATURE_UNAVAILABLE_ON_PLATFORM is incorrectly included in the list of errors that have never been released. It was added in 67e067e and included in every release in the 14.x line. PR-URL: nodejs#34196 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

Trott · 2020-07-05T23:53:17Z

@ronag Still a bug, though, right? If the underlying write stream emits an error, the file handle should not hold the event loop open?

C++ linter fails because of unused ArrayBuffer namespace member PR-URL: nodejs#34212 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

PR-URL: nodejs#34167 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: David Carlier <devnexen@gmail.com>

PR-URL: nodejs#34198 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

test-repl-history-navigation fails with NODE_PENDING_DEPRECATION=1. Replace deprecated repl.inputStream with repl.input. PR-URL: nodejs#34199 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Refs: nodejs#33764 (comment) PR-URL: nodejs#34197 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: nodejs#34158 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Trott · 2020-07-06T17:23:51Z

I think this is ready for review.

I'll try to create a minimal test case that fails on the Raspberry Pi devices when the close() is missing, and then add that to known_issues.

Trott · 2020-07-06T17:24:45Z

I'll also remove the wonky console.log() stuff once Raspberry Pi devices have NODE_DEBUG=test set up in CI.

The test is marked flaky on ARM because it times out on Raspberry Pi devices in CI. Split the single test file into four separate test files to ease debugging. Add fs.close() to avoid timing out. Fixes: nodejs#33796 PR-URL: nodejs#34203 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Robert Nagy <ronagy@icloud.com>

Trott · 2020-07-07T00:33:41Z

Landed in 772fdb0

MylesBorins · 2020-07-14T16:30:17Z

This change is failing on v14.x. Would you be willing to manually backport?

Trott · 2020-07-15T05:46:45Z

This change is failing on v14.x. Would you be willing to manually backport?

Do you mean it's failing to cherry-pick cleanly or that tests are failing or something else? It's cherry-picking cleanly onto v14.x-staging on fa51ac3, so hopefully it's just that something else that needed to land has now landed there and this is good to go...

nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 4, 2020