Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use FromMaybe instead of ToLocal in GetCert #34276

Closed
wants to merge 1 commit into from
Closed

src: use FromMaybe instead of ToLocal in GetCert #34276

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Jul 9, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Jul 9, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32264/

This was referenced Jul 10, 2020
Open
Open
Open
@danbev
Copy link
Contributor Author

danbev commented Jul 13, 2020

Landed in eabe22b.

@danbev danbev closed this Jul 13, 2020
pull bot pushed a commit to suddenlyGiovanni/node that referenced this pull request Jul 13, 2020
@danbev
src: use FromMaybe instead of ToLocal in GetCert
eabe22b 
PR-URL: nodejs#34276
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2020
@danbev @MylesBorins
src: use FromMaybe instead of ToLocal in GetCert
0a2a02d 
PR-URL: #34276
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 14, 2020
Merged
@github-actions github-actions bot mentioned this pull request Jul 15, 2020
Open
13 tasks
MylesBorins pushed a commit that referenced this pull request Jul 16, 2020
@danbev @MylesBorins
src: use FromMaybe instead of ToLocal in GetCert
844bf77 
PR-URL: #34276
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@danbev @addaleax
src: use FromMaybe instead of ToLocal in GetCert
8624fd6 
PR-URL: #34276
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@danbev @addaleax
src: use FromMaybe instead of ToLocal in GetCert
6ddeee4 
PR-URL: #34276
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@danbev @nodejs-github-bot @jasnell @addaleax @tniessen