repl: event ordering: delay 'close' until 'flushHistory' #3435
+17
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fishrock123
added
repl
|
|
||
| return; | ||
| } | ||
| Interface.prototype.close.call(this); |
There was a problem hiding this comment.
maybe this should be called in nextTick?
|
LGTM if CI is happy |
|
so for failures we have:
I don't think any of these are related to the proposed changes. Still LGTM |
|
cc @nodejs/tsc |
|
Code change LGTM. Just squash the commits. |
Fishrock123
force-pushed
the
repl-close-after-flush
branch
from
1f69c51 to
5539b5e
Compare
Emitting 'close' before the history has flushed is somewhat incorrect and rather confusing. This also makes the 'close' event always asynchronous for consistency. Refs: nodejs#2356 PR-URL: nodejs#3435 Reviewed By: Evan Lucas <evanlucas@me.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Fishrock123
force-pushed
the
repl-close-after-flush
branch
from
5539b5e to
ecab7a6
Compare
This was referenced Nov 29, 2023
This was referenced Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emitting close before the history has flushed is somewhat incorrect and
rather confusing.
Fixes an issue related to #2356
Separate PR since I'm going to try to make #2356 work without it, but would already like review here.