Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: repl-persistent-history is no longer flaky #3437

Merged
merged 1 commit into from
Oct 20, 2015

Conversation

Fishrock123
Copy link
Contributor

The race conditions were fixed in
286ef1d

R=@evanlucas?

@Fishrock123 Fishrock123 added the test Issues and PRs related to the tests. label Oct 19, 2015
@evanlucas
Copy link
Contributor

LGTM

@Fishrock123
Copy link
Contributor Author

@jasnell
Copy link
Member

jasnell commented Oct 19, 2015

Potentially unrelated failures in CI need to be verified. Otherwise LGTM.

@Fishrock123
Copy link
Contributor Author

Windows is all net-related stuff, mostly EADDRINUSE...

PPC:

not ok 907 test-debug-args.js
# 
# 
# #
# # Fatal error in , line 0
# # external code buffer is too small
# #
# 
# ==== C stack trace ===============================
# 
# 1: V8_Fatal
# 2: v8::internal::Assembler::GrowBuffer(int)
# 3: v8::internal::Assembler::EmitRelocations()
# 4: v8::internal::Assembler::GetCode(v8::internal::CodeDesc*)
# 5: v8::internal::Builtins::SetUp(v8::internal::Isolate*, bool)
# 6: v8::internal::Isolate::Init(v8::internal::Deserializer*)
# 7: v8::Isolate::New(v8::Isolate::CreateParams const&)
# 8: node::Start(int, char**)
# 9: main
# 10: 0x3fffa93147ac
# 11: __libc_start_main

Seem unrelated?

Another run: https://ci.nodejs.org/job/node-test-pull-request/535/

@jbergstroem
Copy link
Member

@Fishrock123 unrelated; #3390

@jbergstroem
Copy link
Member

LGTM

@Fishrock123 Fishrock123 force-pushed the no-flaky-repl-history branch from e1d896d to 0c38ce4 Compare October 20, 2015 14:43
The race conditions were fixed in
286ef1d

PR-URL: nodejs#3437
Reviewed By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@Fishrock123 Fishrock123 force-pushed the no-flaky-repl-history branch from 0c38ce4 to 5923dee Compare October 20, 2015 14:45
@Fishrock123 Fishrock123 merged commit 5923dee into nodejs:master Oct 20, 2015
@Fishrock123
Copy link
Contributor Author

Thanks, landed in 5923dee

I should probably look at having this run in /parallel/ next..

Fishrock123 added a commit that referenced this pull request Oct 21, 2015
The race conditions were fixed in
286ef1d

PR-URL: #3437
Reviewed By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@rvagg rvagg mentioned this pull request Oct 21, 2015
@MylesBorins
Copy link
Contributor

this should be considered for LTS

/cc @jasnell

Fishrock123 added a commit that referenced this pull request Oct 26, 2015
The race conditions were fixed in
286ef1d

PR-URL: #3437
Reviewed By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@jasnell
Copy link
Member

jasnell commented Oct 26, 2015

Landed in v4.x-staging in 3d1f57d

@Fishrock123
Copy link
Contributor Author

@jasnell you landed the related fix(es) right?

@jasnell
Copy link
Member

jasnell commented Oct 26, 2015

@Fishrock123 .. thanks for the reminder... #2356 (comment)

Fishrock123 added a commit that referenced this pull request Oct 29, 2015
The race conditions were fixed in
286ef1d

PR-URL: #3437
Reviewed By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants