Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add author-ready label ref to onboarding-extras guide #34381

Closed
wants to merge 1 commit into from
Closed

doc: add author-ready label ref to onboarding-extras guide #34381

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion doc/guides/onboarding-extras.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,19 @@ request.
* `tsc-agenda` - Open issues and pull requests with this label will be added to
the Technical Steering Committee meeting agenda

--
---

* `author-ready` - A pull request is _author ready_ when:
* There is a CI run in progress or completed.
* There is at least one Collaborator approval (or two TSC approvals
for semver-major PRs).
* There are no outstanding review comments.

Please always add the `author ready` label to the pull request in that case.
Please always remove it again as soon as the conditions are not met anymore,
such as if CI run fails or a new outstanding review comment is posted.

---

* `semver-{minor,major}`
* be conservative – that is, if a change has the remote *chance* of breaking
Expand Down