Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add iojs installer assets for win & osx #344

Closed
wants to merge 1 commit into from

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Jan 13, 2015

Added visual assets used by WiX on Windows and PackageMaker on OS X to build the native installers.

Added node.ico file with the new io.js logo for Windows.

Review someone please. @piscisaureus?

Added visual assets used by WiX on Windows and PackageMaker on
OS X to build the native installers.
Added node.ico file with the new io.js logo for Windows.
@rvagg
Copy link
Member Author

rvagg commented Jan 13, 2015

I also have updates for tools/osx-pkg.pmdoc but that's more complicated since I'm now templating index.xml to insert version details (should do the same for the Windows installer too), so I'll leave that as a TODO for me

piscisaureus added a commit that referenced this pull request Jan 14, 2015
Added visual assets used by WiX on Windows and PackageMaker on OS X to
build the native installers. Added node.ico file with the new io.js logo
for Windows.

PR: #344
Reviewed-by: Bert Belder <bertbelder@gmail.com>
@piscisaureus
Copy link
Contributor

lgtm. Landed (without the new icon) in 8f7538e.

@rvagg rvagg mentioned this pull request Jan 14, 2015
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants