Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add missing shell option to execSync #3440

Closed
wants to merge 1 commit into from
Closed

docs: add missing shell option to execSync #3440

wants to merge 1 commit into from

Conversation

claudiorodriguez
Copy link
Contributor

Adds the "shell" option from child_process.exec to child_process.execSync on the api docs. Issue #3387

@Fishrock123 Fishrock123 added the doc Issues and PRs related to the documentations. label Oct 19, 2015
@mscdex mscdex added the child_process Issues and PRs related to the child_process subsystem. label Oct 19, 2015
@jasnell
Copy link
Member

jasnell commented Oct 19, 2015

LGTM

@MylesBorins
Copy link
Contributor

@jasnell LTS?

@jasnell
Copy link
Member

jasnell commented Oct 19, 2015

@thealphanerd ... +1

@cjihrig
Copy link
Contributor

cjihrig commented Oct 20, 2015

LGTM

@Trott
Copy link
Member

Trott commented Oct 20, 2015

Nit: first line of commit log message should be less than 50 chars (no big deal if you don't fix it, whoever merges it can fix it, but you'd be saving someone a step)

@claudiorodriguez claudiorodriguez changed the title docs: child_process: adds missing shell option to execSync #3387 docs: add missing shell option to execSync Oct 20, 2015
@claudiorodriguez claudiorodriguez force-pushed the doc-child-process-execsync-missing-shell-option branch from e6f0852 to 1c2f9dd Compare October 20, 2015 13:18
@claudiorodriguez
Copy link
Contributor Author

@Trott Whoops, I'll have to keep that in mind. Fixed. Thanks!

jasnell pushed a commit that referenced this pull request Oct 20, 2015
@jasnell
docs: add missing shell option to execSync
49f965c 
Adds the "shell" option from child_process.exec to
child_process.execSync on the api docs.

Fixes: #3387
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #3440
@jasnell
Copy link
Member

jasnell commented Oct 20, 2015

Landed in 49f965c

@jasnell jasnell closed this Oct 20, 2015
rvagg pushed a commit that referenced this pull request Oct 21, 2015
@rvagg
docs: add missing shell option to execSync
47b06f6 
Adds the "shell" option from child_process.exec to
child_process.execSync on the api docs.

Fixes: #3387
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #3440
@rvagg rvagg mentioned this pull request Oct 21, 2015
Merged
jasnell pushed a commit that referenced this pull request Oct 26, 2015
@jasnell
docs: add missing shell option to execSync
47ab7c7 
Adds the "shell" option from child_process.exec to
child_process.execSync on the api docs.

Fixes: #3387
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #3440
@jasnell
Copy link
Member

jasnell commented Oct 26, 2015

Landed in v4.x-staging in 47ab7c7

@rvagg rvagg mentioned this pull request Oct 28, 2015
Closed
jasnell pushed a commit that referenced this pull request Oct 29, 2015
@jasnell
docs: add missing shell option to execSync
9120a04 
Adds the "shell" option from child_process.exec to
child_process.execSync on the api docs.

Fixes: #3387
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #3440
@leonardoadame leonardoadame mentioned this pull request Nov 28, 2023
Open
@aliscco aliscco mentioned this pull request Nov 28, 2023
Open
@leonardoadame leonardoadame mentioned this pull request Nov 29, 2023
Open
This was referenced Nov 29, 2023
Open
Open
@leonardoadame leonardoadame mentioned this pull request Nov 29, 2023
Open
This was referenced Nov 29, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@claudiorodriguez @jasnell @MylesBorins @cjihrig @Trott @mscdex @Fishrock123