Policy integrity test refactor via permutations #34404
Conversation
nodejs-github-bot
added
esm
| if (!tmpdirURL.pathname.endsWith('/')) { | ||
| tmpdirURL.pathname += '/'; | ||
| function drainQueue() { | ||
| if (spawned < 100 !== true) { |
There was a problem hiding this comment.
Is this really clearer than if (spawned >= 100)?
There was a problem hiding this comment.
don't really agree, but i'm fine changing it
| debug(`stderr: ${Buffer.concat(stderr)}`); | ||
| throw e; | ||
| } | ||
| drainQueue(); |
There was a problem hiding this comment.
This should be inside a finally, right?
There was a problem hiding this comment.
no, we want to stop spawning things if we have an error
| } | ||
| throw new Error('unknown format ' + extension); | ||
| } | ||
| for (const permutation of permutations({ |
|
CI seems to be unhappy with this change, local testing cannot repro. Wondering if this is related to the large number of child processes spawned, I do see some timeouts but other ones simply exit early with a non-zero code, a few are showing problems with the integrity and i also wonder if the number of files written is a problem. |
|
windows failing CI fix is in place, tests are still taking too long and timing out sometimes for CI, unclear on how to fix that. |
|
Landed in b04f2b6 |
PR-URL: #34404 Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #34404 Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #34404 Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #34404 Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #34404 Reviewed-By: James M Snell <jasnell@gmail.com>
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesThis refactors the policy test to do a full set of permutations of various possible configurations. It is rather extensive and thus likely not best to put into fixtures. Along the way a few bugs were found, due to refactors that did not have test coverage such as the new
package_json_readerabstraction. These permutations should cover all the existing 24 variants in the original file and much more (at time of writing it hits 1300 permutations). I have put enough info in thedebuglog('test')to recreate the permutation if you are trying to track down what broke, but it isn't ideal.