Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: revise N-API versions matrix text #34566

Closed
wants to merge 0 commits into from
Closed

doc: revise N-API versions matrix text #34566

wants to merge 0 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 30, 2020

Revise text for clarity, brevity, and conformance with our style guide.

Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. labels Jul 30, 2020
richardlau
richardlau reviewed Jul 30, 2020
View reviewed changes
doc/api/n-api.md Outdated Show resolved Hide resolved
richardlau
richardlau reviewed Jul 30, 2020
View reviewed changes
doc/api/n-api.md Outdated Show resolved Hide resolved
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 30, 2020
mhdawson
mhdawson approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Trott added a commit that referenced this pull request Aug 2, 2020
@Trott
doc: revise N-API versions matrix text
aeaf161 
Revise text for clarity, brevity, and conformance with our style guide.

PR-URL: #34566
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Copy link
Member Author

Trott commented Aug 2, 2020

Landed in aeaf161

@Trott Trott closed this Aug 2, 2020
@Trott Trott deleted the napi-matrix branch August 2, 2020 00:06
codebytere pushed a commit that referenced this pull request Aug 5, 2020
@Trott @codebytere
doc: revise N-API versions matrix text
d7eaf3a 
Revise text for clarity, brevity, and conformance with our style guide.

PR-URL: #34566
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Aug 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@richardlau richardlau richardlau approved these changes

@devsnek devsnek devsnek approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @jasnell @richardlau @devsnek @mhdawson @codebytere @nodejs-github-bot