Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix wrong method call #34629

Closed
wants to merge 1 commit into from
Closed

test: fix wrong method call #34629

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 5, 2020
@gengjiawen gengjiawen requested a review from addaleax August 5, 2020 04:53
@gengjiawen gengjiawen added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 5, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 5, 2020
@gengjiawen gengjiawen mentioned this pull request Aug 5, 2020
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32634/

@mmarchini mmarchini added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 5, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 5, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32635/

This was referenced Aug 6, 2020
Open
Open
Open
Open
This was referenced Aug 8, 2020
Open
Open
@gengjiawen
Copy link
Member Author

Landed in f321144

@gengjiawen gengjiawen closed this Aug 8, 2020
gengjiawen added a commit that referenced this pull request Aug 8, 2020
@gengjiawen
test: fix wrong method call
f321144 
PR-URL: #34629
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Aug 8, 2020
@gengjiawen @addaleax
test: fix wrong method call
e146686 
PR-URL: #34629
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Aug 9, 2020
Open
Open
Open
Open
@codebytere codebytere mentioned this pull request Aug 10, 2020
Merged
This was referenced Aug 11, 2020
Open
Open
codebytere pushed a commit that referenced this pull request Aug 11, 2020
@gengjiawen @codebytere
test: fix wrong method call
33777a3 
PR-URL: #34629
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickyes rickyes rickyes approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@gengjiawen @nodejs-github-bot @jasnell @addaleax @lpinca @cjihrig @richardlau @rickyes @MylesBorins @mmarchini