Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: handle Top-Level Await non-fulfills better #34640

Closed
wants to merge 3 commits into from
Closed

module: handle Top-Level Await non-fulfills better #34640

wants to merge 3 commits into from

Commits on Aug 6, 2020

  1. module: handle Top-Level Await non-fulfills better 

    Handle situations in which the main `Promise` from a TLA module
is not fulfilled better:

- When not resolving the `Promise` at all, set a non-zero exit code
  (unless another one has been requested explicitly) to distinguish
  the result from a successful completion.
- When rejecting the `Promise`, always treat it like an uncaught
  exception. In particular, this also ensures a non-zero exit code.

Refs: nodejs#34558
    @addaleax
    addaleax committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    6dd288e View commit details
    Browse the repository at this point in the history

  2. fixup! module: handle Top-Level Await non-fulfills better

    @addaleax
    addaleax committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    5201960 View commit details
    Browse the repository at this point in the history

  3. fixup! fixup! module: handle Top-Level Await non-fulfills better

    @addaleax
    addaleax committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    9b3aa51 View commit details
    Browse the repository at this point in the history