Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: use sentence-casing for headers in collaborator guide #34713

Merged
merged 0 commits into from
Aug 12, 2020
Merged

doc: use sentence-casing for headers in collaborator guide #34713

merged 0 commits into from
Aug 12, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 10, 2020

The collaborator guide uses both sentence case and headline case for
headings. Use sentence case to conform with our style guide.

Checklist

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 10, 2020
mmarchini
mmarchini approved these changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@mmarchini mmarchini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although maybe some specific terms would benefit from headline case (Breaking Changes, Pull Requests, Long Term Support). Not particularly invested either way, so I'm fine with this landing as is too 🤷🏻‍♀️

@Trott
Copy link
Member Author

Trott commented Aug 12, 2020

Landed in f948359

@Trott Trott closed this Aug 12, 2020
@Trott Trott merged commit f948359 into nodejs:master Aug 12, 2020
@Trott Trott deleted the cg-headers branch August 12, 2020 18:33
MylesBorins pushed a commit that referenced this pull request Aug 17, 2020
@Trott @MylesBorins
doc: use sentence-casing for headers in collaborator guide
f7f3ab8 
The collaborator guide uses both sentence case and headline case for
headings. Use sentence case to conform with our style guide.

PR-URL: #34713
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Aug 20, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
@Trott @BethGriggs
doc: use sentence-casing for headers in collaborator guide
cb09606 
The collaborator guide uses both sentence case and headline case for
headings. Use sentence case to conform with our style guide.

PR-URL: #34713
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
doc: use sentence-casing for headers in collaborator guide
5e7aa03 
The collaborator guide uses both sentence case and headline case for
headings. Use sentence case to conform with our style guide.

PR-URL: #34713
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
doc: use sentence-casing for headers in collaborator guide
f295869 
The collaborator guide uses both sentence case and headline case for
headings. Use sentence case to conform with our style guide.

PR-URL: #34713
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@mmarchini mmarchini mmarchini approved these changes

@iSkore iSkore iSkore approved these changes

@jvmazagao jvmazagao jvmazagao approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Trott @jasnell @lpinca @targos @mmarchini @iSkore @jvmazagao @nodejs-github-bot