-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: move module core module doc to separate page #34747
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
tools
Issues and PRs related to the tools directory.
labels
Aug 12, 2020
aduh95
force-pushed
the
separate-module-core-module-docs
branch
from
August 12, 2020 17:26
90a6282
to
0f741dc
Compare
The `module` core module is available for both CJS and ESM users, it deserves its own page.
aduh95
force-pushed
the
separate-module-core-module-docs
branch
from
August 12, 2020 17:28
0f741dc
to
15c9fae
Compare
guybedford
reviewed
Aug 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think having the stub links is important for backwards compat with doc links.
Whether this can land depends on feedback from previous contributors here further.
addaleax
approved these changes
Aug 13, 2020
@nodejs/documentation @nodejs/website |
addaleax
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
review wanted
PRs that need reviews.
labels
Aug 18, 2020
jasnell
approved these changes
Aug 19, 2020
Landed in 21abb25 |
jasnell
pushed a commit
that referenced
this pull request
Aug 19, 2020
The `module` core module is available for both CJS and ESM users, it deserves its own page. PR-URL: #34747 Refs: nodejs/modules#539 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
3 tasks
BethGriggs
pushed a commit
that referenced
this pull request
Aug 20, 2020
The `module` core module is available for both CJS and ESM users, it deserves its own page. PR-URL: #34747 Refs: nodejs/modules#539 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Aug 20, 2020
The `module` core module is available for both CJS and ESM users, it deserves its own page. PR-URL: #34747 Refs: nodejs/modules#539 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 3, 2020
The `module` core module is available for both CJS and ESM users, it deserves its own page. PR-URL: #34747 Refs: nodejs/modules#539 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2020
The `module` core module is available for both CJS and ESM users, it deserves its own page. PR-URL: #34747 Refs: nodejs/modules#539 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Sep 29, 2022
This was referenced Oct 5, 2022
This was referenced Oct 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
review wanted
PRs that need reviews.
tools
Issues and PRs related to the tools directory.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
module
core module is available for both CJS and ESM users, itdeserves its own page.
Refs: nodejs/modules#539
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes