Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: move module core module doc to separate page #34747

Closed
wants to merge 4 commits into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Aug 12, 2020

The module core module is available for both CJS and ESM users, it
deserves its own page.

Refs: nodejs/modules#539

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/modules

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Aug 12, 2020
@aduh95 aduh95 force-pushed the separate-module-core-module-docs branch from 90a6282 to 0f741dc Compare August 12, 2020 17:26
The `module` core module is available for both CJS and ESM users, it
deserves its own page.
@aduh95 aduh95 force-pushed the separate-module-core-module-docs branch from 0f741dc to 15c9fae Compare August 12, 2020 17:28
Copy link
Contributor

@guybedford guybedford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think having the stub links is important for backwards compat with doc links.

Whether this can land depends on feedback from previous contributors here further.

doc/api/modules.md Outdated Show resolved Hide resolved
.eslintrc.js Outdated Show resolved Hide resolved
@aduh95 aduh95 requested a review from guybedford August 13, 2020 14:39
@guybedford
Copy link
Contributor

This looks good to me but as mentioned I'd like a review from someone who's worked on these docs before - /cc @Trott @bcoe @addaleax @jasnell.

@Trott
Copy link
Member

Trott commented Aug 14, 2020

@nodejs/documentation @nodejs/website

@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. review wanted PRs that need reviews. labels Aug 18, 2020
@jasnell
Copy link
Member

jasnell commented Aug 19, 2020

Landed in 21abb25

@jasnell jasnell closed this Aug 19, 2020
jasnell pushed a commit that referenced this pull request Aug 19, 2020
The `module` core module is available for both CJS and ESM users, it
deserves its own page.

PR-URL: #34747
Refs: nodejs/modules#539
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@GeoffreyBooth GeoffreyBooth mentioned this pull request Aug 19, 2020
3 tasks
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
The `module` core module is available for both CJS and ESM users, it
deserves its own page.

PR-URL: #34747
Refs: nodejs/modules#539
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Aug 20, 2020
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
The `module` core module is available for both CJS and ESM users, it
deserves its own page.

PR-URL: #34747
Refs: nodejs/modules#539
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95 aduh95 deleted the separate-module-core-module-docs branch October 22, 2020 15:56
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
The `module` core module is available for both CJS and ESM users, it
deserves its own page.

PR-URL: #34747
Refs: nodejs/modules#539
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2020
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
The `module` core module is available for both CJS and ESM users, it
deserves its own page.

PR-URL: #34747
Refs: nodejs/modules#539
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. review wanted PRs that need reviews. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants