Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update ESLint to 7.7.0 #34783

Closed
wants to merge 1 commit into from
Closed

tools: update ESLint to 7.7.0 #34783

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Aug 15, 2020

Update ESLint to 7.7.0

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@cjihrig
tools: update ESLint to 7.7.0
36db1e7 
Update ESLint to 7.7.0
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Aug 15, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32807/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 17, 2020 •
edited by cjihrig
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/32809/ 💚

trivikr
trivikr approved these changes Aug 17, 2020
View reviewed changes
Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@cjihrig cjihrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 17, 2020
@jasnell
Copy link
Member

jasnell commented Aug 17, 2020

Landed in 0eca660

jasnell pushed a commit that referenced this pull request Aug 17, 2020
@cjihrig @jasnell
tools: update ESLint to 7.7.0
0eca660 
Update ESLint to 7.7.0

PR-URL: #34783
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell jasnell closed this Aug 17, 2020
@cjihrig cjihrig deleted the eslint branch August 17, 2020 18:46
@MylesBorins
Copy link
Contributor

This doesn't land cleanly on v14.x. Would someone be able to manually backport?

@targos targos added dont-land-on-v14.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-requested-v14.x labels Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cjihrig @nodejs-github-bot @jasnell @MylesBorins @lpinca @BridgeAR @trivikr @targos