src: reduced substring calls #34808
Closed
src: reduced substring calls #34808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
jasnell
approved these changes
Aug 17, 2020
joyeecheung
approved these changes
Aug 21, 2020
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@jasnell @joyeecheung There have been some small changes since your reviews. Can you re-review? |
joyeecheung
approved these changes
Aug 23, 2020
fhinkel
approved these changes
Aug 24, 2020
10 tasks
tniessen
reviewed
Sep 5, 2020
src/node_file.cc
Outdated
| ret.substr(ret.size() - extension.size()) == extension) { | ||
| ret = ret.substr(0, ret.size() - extension.size()); | ||
| if (str_size >= extension.size() && | ||
| // Because we still have the whole string intact |
There was a problem hiding this comment.
I don't really understand this comment. Is it supposed to mean "This is possible because we still have the whole string intact"? If so, it only makes sense in the context of this change. I don't think it explains the code well.
There was a problem hiding this comment.
The intention of the comment is around the choice of using the start index for comparison. Maybe it can be written in a better way. I will work on it.
src/node_file.cc
Outdated
| ret = ret.substr(0, ret.size() - extension.size()); | ||
| if (str_size >= extension.size() && | ||
| // Because we still have the whole string intact | ||
| str.substr(start_pos + str_size - extension.size()) == extension) { |
There was a problem hiding this comment.
If the goal is to remove str.substr (presumably because it allocated memory), why not replace this with str.compare? Or does the compiler optimize this substr call away?
There was a problem hiding this comment.
Not sure about the implementation of compare and how it handles the comparison and allocation but from a higher level point of view it seems valid.
There was a problem hiding this comment.
compare returns an integer. If the strings are equal, the return value is 0.
yashLadha
force-pushed
the
faster_basename
branch
3 times, most recently
from
b3954ad
to
34d7ff5
Compare
Reduced the number of substring calls by 1 as it is a linear time complexity function. Thus having a larger path might lead to decrease in performance. Also removed unnecessary string allocation happening in the block.
yashLadha
force-pushed
the
faster_basename
branch
from
34d7ff5
to
ec75ce2
Compare
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
tniessen
added
the
author ready
aduh95
approved these changes
Oct 11, 2020
aduh95
added
commit-queue
github-actions
bot
removed
the
request-ci
github-actions
bot
removed
the
commit-queue
|
Landed in 4cfa5df...2e4930b |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 11, 2020
Reduced the number of substring calls by 1 as it is a linear time complexity function. Thus having a larger path might lead to decrease in performance. Also removed unnecessary string allocation happening in the block. PR-URL: #34808 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 14, 2020
Reduced the number of substring calls by 1 as it is a linear time complexity function. Thus having a larger path might lead to decrease in performance. Also removed unnecessary string allocation happening in the block. PR-URL: #34808 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Reduced the number of substring calls by 1 as it is a linear time complexity function. Thus having a larger path might lead to decrease in performance. Also removed unnecessary string allocation happening in the block. PR-URL: nodejs#34808 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes