Release clarification and links #3482
Conversation
rvagg
force-pushed
the
release-clarification-and-links
branch
from
d7f4dc4
to
8beb278
Compare
| <https://nodejs.org/download/release/>, listed under their version string. | ||
| The [latest](https://nodejs.org/download/release/latest/) directory is an | ||
| alias for the latest Stable release. The latest LTS release from an LTS | ||
| line is available in the form: latest-lts-_codename_. e.g. |
There was a problem hiding this comment.
note this does not exist yet for Argon, this is just a proposal at this stage
There was a problem hiding this comment.
Nitbike of sheddiest bikenits: I'd avoid e.g. because there are a lot of perfectly intelligent people who don't know what it means (and I'm guessing that's especially true for many non-native speakers). For example: is just fine IMHO.
mscdex
added
the
meta
|
I'm giving a 👍 to "8 months" support for Stable releases that don't turn in to LTS to LF Marketing for this v5 Press Release. @nodejs/tsc should register any objections here before it goes live. |
|
Works for me. |
| Code for Stable releases are organized in this repository by major version | ||
| number, e.g. [v4.x](https://github.com/nodejs/node/tree/v4.x). | ||
| The major version number of Stable releases will increment every 6 months | ||
| allowing for breaking changes to be introduced, this happens in April and |
There was a problem hiding this comment.
Nit: This is a run-on sentence. Change the comma after "introduced" to a period and make "This happens in April..." a separate sentence.
|
Having the Stable/LTS/Nightly etc. stuff all spelled out in the top-level README is a huge improvement. 👍 |
|
LGTM |
rvagg
force-pushed
the
release-clarification-and-links
branch
from
8beb278
to
1fea385
Compare
|
updated with fixes based on suggestions, PTAL, particularly @Trott |
| * **Stable**: planned and signed releases. Released from active development | ||
| branches of this repository and versioned by [SemVer](http://semver.org/). | ||
| Code for Stable releases are organized in this repository by major version | ||
| number, For example:. [v4.x](https://github.com/nodejs/node/tree/v4.x). |
There was a problem hiding this comment.
Maybe go with v5.x rather than v4.x here, just to give people who follow the link the actual current latest Stable.
|
LGTM with a couple comments |
rvagg
force-pushed
the
release-clarification-and-links
branch
from
1fea385
to
9698b3a
Compare
|
Fixed the "There are no breaking ..." thing but left PTAL @Trott |
| each year will convert to LTS (see below) after 6 months and receive further | ||
| support for 30 months. | ||
| * **LTS**: Every second Stable release line (major version) will become LTS | ||
| lines and receive 18 months of _Active LTS_ support and a further 12 |
There was a problem hiding this comment.
Nit: Every second Stable release line will become an LTS line
|
I left three nits, but really, they're trivial even as nits go. LGTM with or without the suggested nit changes. |
rvagg
force-pushed
the
release-clarification-and-links
branch
from
9698b3a
to
eac4bf8
Compare
|
Thanks @Trott, I don't mind bikeshedding the wording on this, it's one of the first things that many people will read so will be good to get it right. I've reworked the wording at the start of each of those dot-points, could you PTAL again? |
rvagg
force-pushed
the
release-clarification-and-links
branch
from
eac4bf8
to
2e1d745
Compare
|
Added a new line near the top: If you need help using or installing Node.js, please use the nodejs/help issue tracker. |
|
Changes LGTM |
|
👍 |
PR-URL: #3482 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #3482 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
|
landed @ 8ceb36c |
PR-URL: #3482 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #3482 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #3482 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
|
landed in v4.x-staging in 208de53 |
PR-URL: #3482 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #3482 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #3482 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #3482 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #3482 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #3482 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #3482 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Some cleaning up and additions to README. Trying to explain the release types is really hard without using lots of words, if you have better wording please suggest it.
Before this gets bogged down in bikeshedding, I'd like to get confirmation from @nodejs/tsc on this point which is something we've floated in discussions but never pinned down as policy:
i.e. every second (odd version as it happens) version will continue to get releases for 8 months max. We will switch to a new Stable after 6 but will allow for a 2 month overlap.
Messaging about this will be going out in a press release and blog post along with v5.0.0 so I'd like this to be pinned down instead of hand-wavy (currently "6 to 8 months").