url: support non-special URLs #34925
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watilde
changed the title
watilde
force-pushed
the
fixes-34899
branch
4 times, most recently
from
1322fdf
to
b2304e6
Compare
watilde
added
the
whatwg-url
watilde
changed the title
watilde
requested review from
targos,
joyeecheung and
Leko
and removed request for
targos
|
As this PR supports a new format of input in whatwg-url, I put |
watilde
added
the
semver-minor
TimothyGu
approved these changes
Sep 16, 2020
Fixes: nodejs#34899 Refs: whatwg/url#505 Refs: web-platform-tests/wpt#25113
watilde
force-pushed
the
fixes-34899
branch
from
b2304e6
to
7156737
Compare
watilde
added
the
author ready
|
Let me cc @nodejs/url for one more review & approval to land. |
jasnell
approved these changes
Sep 19, 2020
watilde
added a commit
that referenced
this pull request
Sep 20, 2020
Fixes: #34899 Refs: whatwg/url#505 Refs: web-platform-tests/wpt#25113 PR-URL: #34925 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in a8971f8 |
|
This does not land cleanly on |
|
@ruyadorno It does not need to land to LTS probably as this patch is depending on #33770 which is |
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Fixes: nodejs#34899 Refs: whatwg/url#505 Refs: web-platform-tests/wpt#25113 PR-URL: nodejs#34925 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WPT Before: web-platform-tests/wpt@6c74b7e
WPT After: web-platform-tests/wpt@551c9d6
Fixes: #34899
Refs: whatwg/url#505
Refs: web-platform-tests/wpt#25113
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes