-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "deps: upgrade npm to 3.3.6" #3493
Conversation
This reverts commit 41923c0.
/cc @iarna |
CI to see if that really does fix the problem on the CI side: https://ci.nodejs.org/job/node-test-pull-request/569/ |
This issue is making all bots go red. |
A fix for this is scheduled in #2286: targos@59c8297. |
@jbergstroem ... there's hope: https://ci.nodejs.org/job/node-test-commit-linux/1000/nodes=debian8-64/console ;-) Looks like reverting this commit saves the day on at least one of the bots so far |
Looks like the |
@iarna ... if we can get a quick patch in that fixes the issue, we can likely avoid the full revert. Given that this has happened before, tho, we likely need to tweak the test process a bit before npm updates land |
Ok, 68471dd landed. Closing this. |
This reverts commit 41923c0.
We ran into the missing module issue again...
https://ci.nodejs.org/job/node-test-commit-osx/987/nodes=osx1010/console
/cc @Fishrock123
Reference to original issue is at #1899