-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: don't compile and test in parallel #3495
Conversation
CI broken because of npm -- I'll rebase once the dust settles. |
Landed the npm fix... |
While invoking `make -j2 test-addons` the rules `all` and `test-build` (as part of `build-addons`) would be run simultaneously. Avoid this by telling `make` to not run `build-addons` in parallel.
8936dfc
to
a5c9ad3
Compare
|
Correct; couldn't find a better alternative. |
To elaborate; |
I guess using |
@bnoordhuis I placed it next to |
I mean .NOTPARALLEL's build-addons prerequisite. If you're using it to document why parallel builds are disabled, a comment is probably in order to explain to casual readers that all targets are serial and why. |
Closing since |
While invoking
make -j2 test-addons
the rulesall
andtest-build
(as part ofbuild-addons
) would be run simultaneously. Avoid this by tellingmake
to not runbuild-addons
in parallel./R=@bnoordhuis ?