Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util: add util.parseArgs() #35015
util: add util.parseArgs() #35015
Changes from 6 commits
1ae63aa
b180e2a
a0221e3
971039c
84b34cc
0034079
d349208
1d5cd77
d64e82a
4dbdca3
97f7e88
b2be252
694f9c6
3a7f3b1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Defaulting to
process.argv.slice(2)
is fine but I think the implementation should somewhat also consider the eval usecase, right now if I try runningnode -p|-e
I get a very unhelpful error:In the past I've done something like
process.argv.slice(require.main ? 2 : 1)
in order to support it (though there might be better ways to handle the check in core).IMO
parseArgs
should either handle eval/script properly OR at least throw an useful error instead 😊There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my request for changes still stands on these