Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: change color contrast for accessibility #35047

Merged
merged 0 commits into from
Sep 4, 2020
Merged

doc: change color contrast for accessibility #35047

merged 0 commits into from
Sep 4, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 4, 2020

Change background color of Stability 1 banner. Previous color contrast
of 3.61:1 fails WCAG AA. New color contrast of 4.50:1 passes.

Checklist

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 4, 2020
@Trott
Copy link
Member Author

Trott commented Sep 4, 2020

Before:

image

After:

image

@Trott
Copy link
Member Author

Trott commented Sep 4, 2020

@nodejs/website

ryzokuken
ryzokuken approved these changes Sep 4, 2020
View reviewed changes
Copy link
Contributor

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change!

MylesBorins
MylesBorins approved these changes Sep 4, 2020
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins
Copy link
Contributor

fast track?

@MylesBorins MylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 4, 2020
@Trott
Copy link
Member Author

Trott commented Sep 4, 2020

Landed in f3b4846

@Trott Trott closed this Sep 4, 2020
@Trott Trott merged commit f3b4846 into nodejs:master Sep 4, 2020
@Trott Trott deleted the stability-1-color branch September 4, 2020 22:53
richardlau pushed a commit that referenced this pull request Sep 7, 2020
@Trott @richardlau
doc: change color contrast for accessibility
0e8a592 
Change background color of Stability 1 banner. Previous color contrast
of 3.61:1 fails WCAG AA. New color contrast of 4.50:1 passes.

PR-URL: #35047
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
@richardlau richardlau mentioned this pull request Sep 7, 2020
Merged
4 tasks
richardlau pushed a commit that referenced this pull request Sep 7, 2020
@Trott @richardlau
doc: change color contrast for accessibility
593236a 
Change background color of Stability 1 banner. Previous color contrast
of 3.61:1 fails WCAG AA. New color contrast of 4.50:1 passes.

PR-URL: #35047
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
doc: change color contrast for accessibility
c83859e 
Change background color of Stability 1 banner. Previous color contrast
of 3.61:1 fails WCAG AA. New color contrast of 4.50:1 passes.

PR-URL: #35047
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
doc: change color contrast for accessibility
2529ba2 
Change background color of Stability 1 banner. Previous color contrast
of 3.61:1 fails WCAG AA. New color contrast of 4.50:1 passes.

PR-URL: #35047
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@Trott @joesepi
doc: change color contrast for accessibility
b0744b8 
Change background color of Stability 1 banner. Previous color contrast
of 3.61:1 fails WCAG AA. New color contrast of 4.50:1 passes.

PR-URL: nodejs#35047
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csabapalfi csabapalfi csabapalfi approved these changes

@XhmikosR XhmikosR XhmikosR approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

@codebytere codebytere codebytere approved these changes

@tniessen tniessen tniessen approved these changes

@ryzokuken ryzokuken ryzokuken approved these changes

@DerekNonGeneric DerekNonGeneric DerekNonGeneric approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Trott @MylesBorins @csabapalfi @XhmikosR @codebytere @tniessen @ryzokuken @DerekNonGeneric @nodejs-github-bot