-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: change stablility-2 color for accessibility #35061
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tniessen
approved these changes
Sep 4, 2020
DerekNonGeneric
approved these changes
Sep 4, 2020
Landed in bb9117e |
Current contrast ratio (2.51) does not pass WCAG AA. This PR increases the contrast to 4.50, which passes WCAG AA. The color, of course, is still green. PR-URL: nodejs#35061 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
richardlau
pushed a commit
that referenced
this pull request
Sep 7, 2020
Current contrast ratio (2.51) does not pass WCAG AA. This PR increases the contrast to 4.50, which passes WCAG AA. The color, of course, is still green. PR-URL: #35061 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
richardlau
pushed a commit
that referenced
this pull request
Sep 7, 2020
Current contrast ratio (2.51) does not pass WCAG AA. This PR increases the contrast to 4.50, which passes WCAG AA. The color, of course, is still green. PR-URL: #35061 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Current contrast ratio (2.51) does not pass WCAG AA. This PR increases the contrast to 4.50, which passes WCAG AA. The color, of course, is still green. PR-URL: #35061 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Current contrast ratio (2.51) does not pass WCAG AA. This PR increases the contrast to 4.50, which passes WCAG AA. The color, of course, is still green. PR-URL: #35061 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Current contrast ratio (2.51) does not pass WCAG AA. This PR increases the contrast to 4.50, which passes WCAG AA. The color, of course, is still green. PR-URL: nodejs#35061 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current contrast ratio (2.51) does not pass WCAG AA. This PR increases
the contrast to 4.50, which passes WCAG AA. The color, of course, is
still green.
Checklist