test: add more valid results to test-trace-atomics-wait #35066
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The two starting `Atomics.wait()` operations are not ordered, but the test assumed a specific ordering because of the latency that comes with spinning up a Worker thread. Add variants of the existing potential valid results that account for the reverse ordering. Fixes: nodejs#35059
richardlau
approved these changes
Sep 5, 2020
github-actions
bot
removed
the
request-ci
|
CI: https://ci.nodejs.org/job/node-test-pull-request/33066/ (:green_heart:) |
Trott
approved these changes
Sep 5, 2020
addaleax
added
author ready
github-actions
bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/35066 ✔ Done loading data for nodejs/node/pull/35066 ----------------------------------- PR info ------------------------------------ Title test: add more valid results to test-trace-atomics-wait (#35066) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch addaleax:atomics-wait-trace-add -> nodejs:master Labels author ready, test Commits 1 - test: add more valid results to test-trace-atomics-wait Committers 1 - Anna Henningsen PR-URL: https://github.com/nodejs/node/pull/35066 Fixes: https://github.com/nodejs/node/issues/35059 Reviewed-By: Richard Lau Reviewed-By: Rich Trott ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/35066 Fixes: https://github.com/nodejs/node/issues/35059 Reviewed-By: Richard Lau Reviewed-By: Rich Trott -------------------------------------------------------------------------------- ✖ Last GitHub CI failed ℹ Last Full PR CI on 2020-09-05T11:16:49Z: https://ci.nodejs.org/job/node-test-pull-request/33066/ - Querying data for job/node-test-pull-request/33066/ ✔ Build data downloaded ✔ Last Jenkins CI successful ℹ This PR was created on Sat, 05 Sep 2020 10:58:15 GMT ✔ Approvals: 2 ✔ - Richard Lau (@richardlau): https://github.com/nodejs/node/pull/35066#pullrequestreview-483048152 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/35066#pullrequestreview-483061546 -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu |
github-actions
bot
added
the
commit-queue-failed
|
Landed in e06037a |
addaleax
added a commit
that referenced
this pull request
Sep 7, 2020
The two starting `Atomics.wait()` operations are not ordered, but the test assumed a specific ordering because of the latency that comes with spinning up a Worker thread. Add variants of the existing potential valid results that account for the reverse ordering. Fixes: #35059 PR-URL: #35066 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
ruyadorno
pushed a commit
that referenced
this pull request
Sep 17, 2020
The two starting `Atomics.wait()` operations are not ordered, but the test assumed a specific ordering because of the latency that comes with spinning up a Worker thread. Add variants of the existing potential valid results that account for the reverse ordering. Fixes: #35059 PR-URL: #35066 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
The two starting `Atomics.wait()` operations are not ordered, but the test assumed a specific ordering because of the latency that comes with spinning up a Worker thread. Add variants of the existing potential valid results that account for the reverse ordering. Fixes: nodejs#35059 PR-URL: nodejs#35066 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
removed
the
commit-queue-failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two starting
Atomics.wait()operations are not ordered,but the test assumed a specific ordering because of the latency
that comes with spinning up a Worker thread.
Add variants of the existing potential valid results that account
for the reverse ordering.
Fixes: #35059
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes