Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repl: handle comments properly #3515

Closed
wants to merge 2 commits into from
Closed

repl: handle comments properly #3515

wants to merge 2 commits into from

Commits on Oct 26, 2015

  1. repl: handle comments properly 

    As it is, the comments are not handled properly in REPL. So, if the
comments have `'` or `"`, then they are treated as string literals and
the error is thrown in REPL.

This patch refactors the existing logic and groups everything in a
class.

Fixes: nodejs#3421
    @thefourtheye
    thefourtheye committed Oct 26, 2015
    Configuration menu
    Copy the full SHA
    5f656db View commit details
    Browse the repository at this point in the history

  2. addressing targos's comments

    @thefourtheye
    thefourtheye committed Oct 26, 2015
    Configuration menu
    Copy the full SHA
    60aeee5 View commit details
    Browse the repository at this point in the history