lib: change ERR_INVALID_ARG_VALUE error message #35156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
errors
github-actions
bot
removed
the
request-ci
Trott
reviewed
Sep 14, 2020
| @@ -12,7 +12,7 @@ const dnsPromises = require('dns').promises; | |||
| { | |||
| code: 'ERR_INVALID_ARG_VALUE', | |||
| name: 'TypeError', | |||
| message: `The argument 'rrtype' is invalid. Received '${rrtype}'` | |||
| message: `The 'rrtype' is invalid. Received '${rrtype}' argument` | |||
There was a problem hiding this comment.
Looks like argument ended up in the wrong place in this string?
There was a problem hiding this comment.
Oh, good catch. Do we have a make command to run all tests?
There was a problem hiding this comment.
make test-all-suites
I would have used make test-all but it was already taken.
github-actions
bot
removed
the
request-ci
|
This would need a rebase. |
|
This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open. |
|
Closing this because it has stalled. Feel free to reopen if this issue/PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #34682
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes/cc @BridgeAR @jasnell @Trott