Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: various grammatical fixes #35203

Merged
merged 1 commit into from
Sep 17, 2020
Merged

doc: various grammatical fixes #35203

merged 1 commit into from
Sep 17, 2020

Conversation

wjabbour
Copy link
Contributor

  • documentation is changed or added
  • commit message follows [commit guidelines]

Increase readability, fix grammatical issues

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. labels Sep 15, 2020
@wjabbour @Trott
doc: fix small grammatical issues in timers.md
59ca56e 
PR-URL: nodejs#35203
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented Sep 17, 2020

Landed in 59ca56e

@Trott Trott merged commit 59ca56e into nodejs:master Sep 17, 2020
ruyadorno pushed a commit that referenced this pull request Sep 21, 2020
@wjabbour @ruyadorno
doc: fix small grammatical issues in timers.md
64ac5c6 
PR-URL: #35203
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Sep 21, 2020
Merged
4 tasks
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@wjabbour @addaleax
doc: fix small grammatical issues in timers.md
f050ecc 
PR-URL: #35203
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@wjabbour @joesepi
doc: fix small grammatical issues in timers.md
140c5db 
PR-URL: nodejs#35203
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wjabbour @Trott @addaleax @nodejs-github-bot