Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: stream write(chunk, encoding, cb) encoding can be null #35372

Merged
merged 1 commit into from
Nov 9, 2020
Merged

doc: stream write(chunk, encoding, cb) encoding can be null #35372

merged 1 commit into from
Nov 9, 2020

Conversation

dev-script
Copy link
Contributor

In stream write encoding can be null.

Fixes: #33715

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Sep 27, 2020
@dev-script dev-script mentioned this pull request Sep 27, 2020
Closed
3 tasks
@mscdex
Copy link
Contributor

mscdex commented Sep 27, 2020

The targeted subsystem in the commit message should be doc instead of stream.

@dev-script dev-script changed the title stream: write(chunk, encoding, cb) encoding can be null doc: write(chunk, encoding, cb) encoding can be null Sep 27, 2020
@dev-script dev-script changed the title doc: write(chunk, encoding, cb) encoding can be null doc: stream write(chunk, encoding, cb) encoding can be null Sep 27, 2020
@dev-script
Copy link
Contributor Author

The targeted subsystem in the commit message should be doc instead of stream.

I have done changes. please review

@lpinca
Copy link
Member

lpinca commented Sep 30, 2020

Any falsy value for the encoding argument works in the same way.

node/lib/internal/streams/writable.js

Lines 293 to 294 in ee9e3e7

if (!encoding)
encoding = state.defaultEncoding;

Not sure if it is ok to add only null.

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 8, 2020
@aduh95 aduh95 force-pushed the doc/stream-write-encoding branch from d4a718d to 934faa0 Compare November 9, 2020 18:13
@dev-script @aduh95
doc,stream: write(chunk, encoding, cb) encoding can be null
caa5a05 
In stream write encoding can be null.

Fixes: nodejs#33715

PR-URL: nodejs#35372
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 force-pushed the doc/stream-write-encoding branch from 934faa0 to caa5a05 Compare November 9, 2020 18:15
@aduh95
Copy link
Contributor

aduh95 commented Nov 9, 2020

Landed in caa5a05

@aduh95 aduh95 merged commit caa5a05 into nodejs:master Nov 9, 2020
danielleadams pushed a commit that referenced this pull request Nov 9, 2020
@dev-script @danielleadams
doc,stream: write(chunk, encoding, cb) encoding can be null
36c20d9 
In stream write encoding can be null.

Fixes: #33715

PR-URL: #35372
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams danielleadams mentioned this pull request Nov 9, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 9, 2020
@dev-script @BethGriggs
doc,stream: write(chunk, encoding, cb) encoding can be null
ddec68a 
In stream write encoding can be null.

Fixes: #33715

PR-URL: #35372
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@dev-script @BethGriggs
doc,stream: write(chunk, encoding, cb) encoding can be null
62741b5 
In stream write encoding can be null.

Fixes: #33715

PR-URL: #35372
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@dev-script @BethGriggs
doc,stream: write(chunk, encoding, cb) encoding can be null
0a944a4 
In stream write encoding can be null.

Fixes: #33715

PR-URL: #35372
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A possible TODO list for new (or current) contributors
5 participants
@dev-script @mscdex @lpinca @aduh95 @nodejs-github-bot