Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v14.x backport] test: update wpt tests for encoding #35422

Closed
wants to merge 1 commit into from
Closed

[v14.x backport] test: update wpt tests for encoding #35422

wants to merge 1 commit into from

Conversation

watilde
Copy link
Member

@watilde watilde commented Sep 30, 2020 •
edited
Loading

Refs: web-platform-tests/wpt#25542

PR-URL: #35330
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Shingo Inoue leko.noor@gmail.com
Reviewed-By: Rich Trott rtrott@gmail.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@watilde
test: update wpt tests for encoding
a00ecd6 
Refs: web-platform-tests/wpt#25542

PR-URL: nodejs#35330
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. v14.x labels Sep 30, 2020
@watilde watilde mentioned this pull request Sep 30, 2020
Closed
3 tasks
@watilde watilde added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 30, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 30, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33302/

@watilde
Copy link
Member Author

watilde commented Oct 6, 2020

@MylesBorins Could you have a chance to review this?

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33416/

MylesBorins
MylesBorins approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielleadams
Copy link
Contributor

danielleadams commented Oct 6, 2020 •
edited by targos
Loading

Landed in 552ebaf

danielleadams pushed a commit that referenced this pull request Oct 6, 2020
@watilde @danielleadams
test: update wpt tests for encoding
552ebaf 
Refs: web-platform-tests/wpt#25542

PR-URL: #35330
Backport-PR-URL: #35422
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethGriggs BethGriggs BethGriggs approved these changes

@danielleadams danielleadams danielleadams approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@watilde @nodejs-github-bot @danielleadams @MylesBorins @BethGriggs