Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: enable Clang-cl Windows builds #35433

Closed
wants to merge 12 commits into from
Closed

build: enable Clang-cl Windows builds #35433

wants to merge 12 commits into from

Commits on Apr 30, 2024

  1. tools: hack gyp to generate clang-cl solutions

    @targos
    targos committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    ff3a4ec View commit details
    Browse the repository at this point in the history

  2. deps: add missing zlib includes 

    TODO: upstream change to Chromium
    @targos
    targos committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    26e51ff View commit details
    Browse the repository at this point in the history

  3. hack ICU

    @targos
    targos committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    711a822 View commit details
    Browse the repository at this point in the history

  4. disable some workflows

    @targos
    targos committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    bbf0efc View commit details
    Browse the repository at this point in the history

  5. remove macros

    @targos
    targos committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    3ccb17d View commit details
    Browse the repository at this point in the history

  6. set clang to 1

    @targos
    targos committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    273cb2b View commit details
    Browse the repository at this point in the history

  7. fix pch

    @targos
    targos committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    6ec7554 View commit details
    Browse the repository at this point in the history

  8. fix build on clangcl, except for v8 assembly (#9) 

    1. To avoid many warnings, this PR declares the C and C++ standards separately.
2. This PR extends gyp so that we can build with AVX-512. Nevertheless, getting runtime dispatching with ClangCl through Visual Studio is challenging, so we disable it. It only affects one component of zip, so the effect on runtime performance should be negligible. Note that other dependencies such as simdutf do not need to this build support for runtime dispatching (so you still get AVX2, AVX-512 support in these dependencies).
    @lemire @targos
    lemire authored and targos committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    1f149ca View commit details
    Browse the repository at this point in the history

  9. fix: embed snapshot asm into a source file like v8 does

    @lemire @targos
    lemire authored and targos committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    d4fe780 View commit details
    Browse the repository at this point in the history

  10. fix: lib paths and remove unneeded masm

    @lemire @targos
    lemire authored and targos committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    9d7c136 View commit details
    Browse the repository at this point in the history

  11. fix: only build embedded.cc when under Windows. (#11)

    @lemire @targos
    lemire authored and targos committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    1a5726a View commit details
    Browse the repository at this point in the history

  12. fix: only generate embedded.cc under Windows. (#12)

    @lemire @targos
    lemire authored and targos committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    d5302f5 View commit details
    Browse the repository at this point in the history