src: move node_process to modern THROW_ERR* #35472
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell
added
semver-minor
nodejs-github-bot
added
the
c++
github-actions
bot
removed
the
request-ci
Not going to fight it or anything, but isn't this backwards? Isn't the idea that message changes are semver-patch and changing (or adding) a code to an error is semver-major? |
Is there a use case for this and/or a record of it causing problems for folks? Or is the motive more about internal consistency? |
Oh, wait, I see... semver-minor and not semver-patch, on the grounds that adding a code is minor but changing a code would be major. Sure. I would have thought major out of caution would be the default, but I also think the approach here makes sense so... ¯\(ツ)/¯ |
joyeecheung
approved these changes
Oct 4, 2020
jasnell
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/35472 ✔ Done loading data for nodejs/node/pull/35472 ----------------------------------- PR info ------------------------------------ Title src: move node_process to modern THROW_ERR* (#35472) Author James M Snell (@jasnell) Branch jasnell:node_process_errors -> nodejs:master Labels C++, errors, lib / src, semver-minor Commits 1 - src: move node_process to modern THROW_ERR* Committers 1 - James M Snell PR-URL: https://github.com/nodejs/node/pull/35472 Reviewed-By: Joyee Cheung ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/35472 Reviewed-By: Joyee Cheung -------------------------------------------------------------------------------- ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2020-10-04T00:50:42Z: https://ci.nodejs.org/job/node-test-pull-request/33359/ - Querying data for job/node-test-pull-request/33359/ ✔ Build data downloaded ✔ Last Jenkins CI successful ℹ This PR was created on Fri, 02 Oct 2020 21:52:07 GMT ✔ Approvals: 1 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/35472#pullrequestreview-501630565 ✖ This PR needs to wait 100 more hours to land (or 0 hours if there is one more approval) -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu |
github-actions
bot
added
the
commit-queue-failed
jasnell
removed
the
commit-queue-failed
jasnell
added a commit
that referenced
this pull request
Oct 10, 2020
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #35472 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
|
Landed in b28ba4b |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 14, 2020
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #35472 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 3, 2020
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #35472 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
MylesBorins
added a commit
that referenced
this pull request
Nov 3, 2020
Notable changes: crypto: * update certdata to NSS 3.56 (Shelley Vohr) #35546 deps: * update llhttp to 2.1.3 (Fedor Indutny) #35435 * (SEMVER-MINOR) upgrade to libuv 1.40.0 (Colin Ihrig) #35333 doc: * add aduh95 to collaborators (Antoine du Hamel) #35542 fs: * (SEMVER-MINOR) add .ref() and .unref() methods to watcher classes (rickyes) #33134 http: * (SEMVER-MINOR) added scheduling option to http agent (delvedor) #33278 module: * (SEMVER-MINOR) exports pattern support (Guy Bedford) #34718 * (SEMVER-MINOR) named exports for CJS via static analysis (Guy Bedford) #35249 n-api: * (SEMVER-MINOR) add more property defaults (Gerhard Stoebich) #35214 src: * (SEMVER-MINOR) move node_contextify to modern THROW_ERR_* (James M Snell) #35470 * (SEMVER-MINOR) move node_process to modern THROW_ERR* (James M Snell) #35472 * (SEMVER-MINOR) expose v8::Isolate setup callbacks (Shelley Vohr) #35512 PR-URL: TODO
Merged
MylesBorins
added a commit
that referenced
this pull request
Nov 4, 2020
Notable changes: crypto: * update certdata to NSS 3.56 (Shelley Vohr) #35546 deps: * update llhttp to 2.1.3 (Fedor Indutny) #35435 * (SEMVER-MINOR) upgrade to libuv 1.40.0 (Colin Ihrig) #35333 doc: * add aduh95 to collaborators (Antoine du Hamel) #35542 fs: * (SEMVER-MINOR) add .ref() and .unref() methods to watcher classes (rickyes) #33134 http: * (SEMVER-MINOR) added scheduling option to http agent (delvedor) #33278 module: * (SEMVER-MINOR) exports pattern support (Guy Bedford) #34718 * (SEMVER-MINOR) named exports for CJS via static analysis (Guy Bedford) #35249 n-api: * (SEMVER-MINOR) add more property defaults (Gerhard Stoebich) #35214 src: * (SEMVER-MINOR) move node_contextify to modern THROW_ERR_* (James M Snell) #35470 * (SEMVER-MINOR) move node_process to modern THROW_ERR* (James M Snell) #35472 * (SEMVER-MINOR) expose v8::Isolate setup callbacks (Shelley Vohr) #35512 PR-URL: TODO
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2020
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #35472 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
MylesBorins
added a commit
that referenced
this pull request
Nov 16, 2020
Notable changes: crypto: * update certdata to NSS 3.56 (Shelley Vohr) #35546 deps: * update llhttp to 2.1.3 (Fedor Indutny) #35435 * (SEMVER-MINOR) upgrade to libuv 1.40.0 (Colin Ihrig) #35333 doc: * add aduh95 to collaborators (Antoine du Hamel) #35542 fs: * (SEMVER-MINOR) add .ref() and .unref() methods to watcher classes (rickyes) #33134 http: * (SEMVER-MINOR) added scheduling option to http agent (delvedor) #33278 module: * (SEMVER-MINOR) exports pattern support (Guy Bedford) #34718 * (SEMVER-MINOR) named exports for CJS via static analysis (Guy Bedford) #35249 n-api: * (SEMVER-MINOR) add more property defaults (Gerhard Stoebich) #35214 src: * (SEMVER-MINOR) move node_contextify to modern THROW_ERR_* (James M Snell) #35470 * (SEMVER-MINOR) move node_process to modern THROW_ERR* (James M Snell) #35472 * (SEMVER-MINOR) expose v8::Isolate setup callbacks (Shelley Vohr) #35512 PR-URL: #35950
This was referenced Jun 23, 2021
Closed
This was referenced Jul 1, 2021
This was referenced Jul 11, 2021
This was referenced Jul 23, 2021
This was referenced Jul 31, 2021
1 task
1 task
This was referenced Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Semver-minor because it adds a code. Not semver-major because the error messages do not change. There is one changed detail tho: previously a couple of these functions would throw if too many arguments were passed in. I've relaxed that here given that it's not a check we consistently apply throughout.
Signed-off-by: James M Snell jasnell@gmail.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes