-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: edit fs.md for minor style changes #35505
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
fs
Issues and PRs related to the fs subsystem / file system.
labels
Oct 5, 2020
@nodejs/documentation |
aymen94
approved these changes
Oct 7, 2020
👍 LGTM |
@nodejs/fs |
watilde
approved these changes
Oct 8, 2020
Trott
force-pushed
the
fs-might
branch
3 times, most recently
from
October 12, 2020 14:11
e0bdf2c
to
ab2503d
Compare
Prefer present tense and use "might" for possibility. PR-URL: nodejs#35505 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Landed in a844387 |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 14, 2020
Prefer present tense and use "might" for possibility. PR-URL: #35505 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Prefer present tense and use "might" for possibility. PR-URL: nodejs#35505 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
This was referenced Sep 29, 2022
This was referenced Oct 5, 2022
This was referenced Oct 8, 2022
This was referenced Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefer present tense and use "might" for possibility.
Checklist