Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: edit fs.md for minor style changes #35505

Merged
merged 1 commit into from
Oct 12, 2020
Merged

doc: edit fs.md for minor style changes #35505

merged 1 commit into from
Oct 12, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 5, 2020

Prefer present tense and use "might" for possibility.

Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Oct 5, 2020
@Trott
Copy link
Member Author

Trott commented Oct 7, 2020

@nodejs/documentation

@aymen94
Copy link
Member

aymen94 commented Oct 7, 2020

👍 LGTM

@Trott
Copy link
Member Author

Trott commented Oct 8, 2020

@nodejs/fs

@Trott Trott force-pushed the fs-might branch 3 times, most recently from e0bdf2c to ab2503d Compare October 12, 2020 14:11
Prefer present tense and use "might" for possibility.

PR-URL: nodejs#35505
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@Trott
Copy link
Member Author

Trott commented Oct 12, 2020

Landed in a844387

@Trott Trott merged commit a844387 into nodejs:master Oct 12, 2020
@Trott Trott deleted the fs-might branch October 12, 2020 14:17
MylesBorins pushed a commit that referenced this pull request Oct 14, 2020
Prefer present tense and use "might" for possibility.

PR-URL: #35505
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 14, 2020
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
Prefer present tense and use "might" for possibility.

PR-URL: nodejs#35505
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants