Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: more crypto cleanup #35509

Closed
wants to merge 2 commits into from
Closed

src: more crypto cleanup #35509

wants to merge 2 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Oct 5, 2020 •
edited
Loading

This builds on #35093 which must land first.

Continued/ongoing cleanup of crypto internals. This one factoring out toLocalChecked usage.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@jasnell jasnell requested a review from a team October 5, 2020 21:07
@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Oct 5, 2020
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/tsc

@jasnell jasnell changed the title More crypto cleanup src: more crypto cleanup Oct 5, 2020
@Trott Trott added the blocked PRs that are blocked by other issues or PRs. label Oct 6, 2020
@Trott
Copy link
Member

Trott commented Oct 6, 2020

Added blocked label which can be removed when #35093 lands.

@jasnell
src: replace more toLocalCheckeds in crypto_*
e409e1b 
Signed-off-by: James M Snell <jasnell@gmail.com>
@jasnell
src: remove toLocalChecked in crypto_context
ce5c6c9 
Signed-off-by: James M Snell <jasnell@gmail.com>
@jasnell jasnell added request-ci Add this label to start a Jenkins CI on a PR. and removed blocked PRs that are blocked by other issues or PRs. labels Oct 8, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 8, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33469/

@jasnell jasnell added crypto Issues and PRs related to the crypto subsystem. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 10, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 10, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 13, 2020 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/33584/ 💚

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 13, 2020
jasnell added a commit that referenced this pull request Oct 13, 2020
@jasnell
src: replace more toLocalCheckeds in crypto_*
17d5d94 
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #35509
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
jasnell added a commit that referenced this pull request Oct 13, 2020
@jasnell
src: remove toLocalChecked in crypto_context
f7ed5f4 
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #35509
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@jasnell
Copy link
Member Author

jasnell commented Oct 13, 2020

Landed in 17d5d94 and f7ed5f4

@jasnell jasnell closed this Oct 13, 2020
@MylesBorins
Copy link
Contributor

as this builds on a semver-major commit I've added the dont-land label for older release lines

joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@jasnell @joesepi
src: replace more toLocalCheckeds in crypto_*
9eb615d 
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: nodejs#35509
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@jasnell @joesepi
src: remove toLocalChecked in crypto_context
b3c62cf 
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: nodejs#35509
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jasnell @nodejs-github-bot @Trott @MylesBorins @addaleax