src: remove asyncwrapobject #35511
Closed
src: remove asyncwrapobject #35511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
the
lib / src
addaleax
approved these changes
Oct 5, 2020
Me: Can we remove stuff? |
Trott
approved these changes
Oct 6, 2020
|
Adding the |
jasnell
force-pushed
the
remove-asyncwrapobject
branch
from
50226ce
to
44ddac1
Compare
jasnell
added
request-ci
github-actions
bot
removed
the
request-ci
|
Relevant lint error: |
Following the crypto subsystem refactor, this is now unused. Begone!! Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell
force-pushed
the
remove-asyncwrapobject
branch
from
245c9ab
to
27e418b
Compare
|
Landed in 83eaaf9 |
jasnell
added a commit
that referenced
this pull request
Oct 10, 2020
Following the crypto subsystem refactor, this is now unused. Begone!! Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #35511 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
|
This appears to build on a semver major change so I'm adding the dont land labels for older release lines |
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Following the crypto subsystem refactor, this is now unused. Begone!! Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: nodejs#35511 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See, I remove code sometimes also!
Once #35093 lands, the AsyncWrapObject will no longer be used. #35093 must land before this.
/cc @addaleax
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes