Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix Commit Queue failure comment #35599

Merged
merged 1 commit into from
Oct 14, 2020
Merged

build: fix Commit Queue failure comment #35599

merged 1 commit into from
Oct 14, 2020

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Oct 11, 2020

Refs: #35206

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 11, 2020
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 11, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 11, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33530/

lundibundi
lundibundi approved these changes Oct 12, 2020
View reviewed changes
tools/actions/commit-queue.sh Show resolved Hide resolved
@aduh95 @Trott
build: fix Commit Queue failure comment
ac5df63 
Refs: nodejs#35206

PR-URL: nodejs#35599
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented Oct 14, 2020

Landed in ac5df63

@Trott Trott merged commit ac5df63 into nodejs:master Oct 14, 2020
@aduh95 aduh95 deleted the fix-cq-failure-comment branch October 14, 2020 13:16
MylesBorins pushed a commit that referenced this pull request Oct 14, 2020
@aduh95 @MylesBorins
build: fix Commit Queue failure comment
16c17dd 
Refs: #35206

PR-URL: #35599
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 14, 2020
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@aduh95 @joesepi
build: fix Commit Queue failure comment
2b45bde 
Refs: nodejs#35206

PR-URL: nodejs#35599
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lundibundi lundibundi lundibundi approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aduh95 @nodejs-github-bot @Trott @lundibundi