src,crypto: refactoring of crypto_context, SecureContext #35665
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
|
Review requested:
|
jasnell
added
crypto
github-actions
bot
removed
the
request-ci
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
mildsunrise
approved these changes
Oct 17, 2020
tniessen
approved these changes
Oct 17, 2020
Trott
reviewed
Oct 18, 2020
Trott
reviewed
Oct 18, 2020
This comment has been minimized.
This comment has been minimized.
Trott
approved these changes
Oct 18, 2020
github-actions
bot
removed
the
request-ci
fhinkel
approved these changes
Oct 19, 2020
jasnell
force-pushed
the
crypto-cleanup-securecontext
branch
from
30ac425
to
1f8120c
Compare
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
jasnell
force-pushed
the
crypto-cleanup-securecontext
branch
from
1f8120c
to
33e7a62
Compare
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
jasnell
added
the
author ready
This comment has been minimized.
This comment has been minimized.
aduh95
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/35665 ✔ Done loading data for nodejs/node/pull/35665 ----------------------------------- PR info ------------------------------------ Title src,crypto: refactoring of crypto_context, SecureContext (#35665) Author James M Snell (@jasnell) Branch jasnell:crypto-cleanup-securecontext -> nodejs:master Labels C++, author ready, crypto, errors, tls Commits 1 - src,crypto: refactoring of crypto_context, SecureContext Committers 1 - James M Snell PR-URL: https://github.com/nodejs/node/pull/35665 Reviewed-By: Alba Mendez Reviewed-By: Tobias Nießen Reviewed-By: Rich Trott Reviewed-By: Franziska Hinkelmann ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/35665 Reviewed-By: Alba Mendez Reviewed-By: Tobias Nießen Reviewed-By: Rich Trott Reviewed-By: Franziska Hinkelmann -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - src,crypto: refactoring of crypto_context, SecureContext ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2020-11-10T09:45:35Z: https://ci.nodejs.org/job/node-test-pull-request/34275/ - Querying data for job/node-test-pull-request/34275/ ✔ Build data downloaded ✔ Last Jenkins CI successful ℹ This PR was created on Thu, 15 Oct 2020 23:54:44 GMT ✔ Approvals: 4 ✔ - Alba Mendez (@mildsunrise): https://github.com/nodejs/node/pull/35665#pullrequestreview-510987295 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/35665#pullrequestreview-511000285 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/35665#pullrequestreview-511141489 ✔ - Franziska Hinkelmann (@fhinkel) (TSC): https://github.com/nodejs/node/pull/35665#pullrequestreview-511619185 -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu Commit Queue action: https://github.com/nodejs/node/actions/runs/356556511 |
github-actions
bot
added
the
commit-queue-failed
aduh95
reviewed
Nov 10, 2020
aduh95
removed
author ready
Cleaup and improvement of crypto_context and SecureContext. Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell
force-pushed
the
crypto-cleanup-securecontext
branch
from
33e7a62
to
99dde03
Compare
aduh95
approved these changes
Nov 11, 2020
jasnell
added a commit
that referenced
this pull request
Nov 11, 2020
Cleaup and improvement of crypto_context and SecureContext. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #35665 Reviewed-By: Alba Mendez <me@alba.sh> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
|
Landed in 35274cb |
codebytere
pushed a commit
that referenced
this pull request
Nov 22, 2020
Cleaup and improvement of crypto_context and SecureContext. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #35665 Reviewed-By: Alba Mendez <me@alba.sh> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Merged
|
Hey, this broke socket.io which passes null as the pfx value - it has been fixed since but worth mentioning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaup and improvement of crypto_context and SecureContext.
This is semver-major primarily because of changes to error messages.
Signed-off-by: James M Snell jasnell@gmail.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes