Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: fix file url reparse #35671

Closed
wants to merge 1 commit into from
Closed

url: fix file url reparse #35671

wants to merge 1 commit into from

Conversation

watilde
Copy link
Member

@watilde watilde commented Oct 16, 2020

Fixes: #35571
Refs: whatwg/url#550
Refs: web-platform-tests/wpt#25989

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@watilde watilde added the whatwg-url Issues and PRs related to the WHATWG URL implementation. label Oct 16, 2020
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Oct 16, 2020
@watilde watilde added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 16, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 16, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33657/

@watilde
Copy link
Member Author

watilde commented Oct 19, 2020

Let me cc @nodejs/url to request more reviews

watilde added a commit that referenced this pull request Oct 19, 2020
@watilde
url: fix file url reparse
7afe3af 
Fixes: #35571
Refs: whatwg/url#550
Refs: web-platform-tests/wpt#25989

PR-URL: #35671
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@watilde
Copy link
Member Author

watilde commented Oct 19, 2020

Landed in 7afe3af

@watilde watilde closed this Oct 19, 2020
@watilde watilde deleted the file-url-reparse branch October 19, 2020 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel fhinkel approved these changes

@Trott Trott Trott approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

URL spec change: file URL reparse issue
5 participants
@watilde @nodejs-github-bot @fhinkel @Trott @targos