doc: Document version introducing ChildProcess 'spawn' event #35846
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces a placeholder that was added in the commit which added the new ChildProcess 'spawn' event. Refs: nodejs#35369
nodejs-github-bot
added
child_process
|
@zenflow - we don't have to do explicitly, when a release is being |
|
I see that you had asked this question earlier, sorry - I missed it. |
aduh95
requested changes
Oct 28, 2020
There was a problem hiding this comment.
We do it like this so we can document multiple versions when features get backported to LTS lines. The PR you are referencing is labeled semver-minor, it should land on v15 first, and 2+ weeks later on v14 and v12. Nothing to do on your side unless the commit doesn't land cleanly in case a manual backport will be requested.
|
@gireeshpunathil Thanks and no problem! :) |
|
@aduh95 Awesome! Thanks for explaining how this works, very helpful :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces a placeholder that was added in the commit which added
the new ChildProcess 'spawn' event.
Refs: #35369
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passestests and/or benchmarks are includedAs per my final paragraph in this comment
/cc @gireeshpunathil