-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add test to fs/promises setImmediate #35852
Merged
Trott
merged 1 commit into
nodejs:master
from
tyankatsu0105:coverage/test-timers-promisifiled
Oct 31, 2020
Merged
test: add test to fs/promises setImmediate #35852
Trott
merged 1 commit into
nodejs:master
from
tyankatsu0105:coverage/test-timers-promisifiled
Oct 31, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yosuke-furukawa
approved these changes
Oct 28, 2020
shisama
approved these changes
Oct 28, 2020
benjamingr
approved these changes
Oct 28, 2020
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Oct 28, 2020
Leko
approved these changes
Oct 28, 2020
watilde
approved these changes
Oct 28, 2020
rickyes
approved these changes
Oct 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Oct 29, 2020
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Oct 29, 2020
Trott
approved these changes
Oct 29, 2020
3 tasks
rickyes
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Oct 31, 2020
Add test pattern to setImmediate when ref's type is not boolean PR-URL: nodejs#35852 Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Trott
force-pushed
the
coverage/test-timers-promisifiled
branch
from
October 31, 2020 11:48
b08259a
to
5dd344a
Compare
Landed in 5dd344a |
Thanks for the contribution! 🎉 |
targos
pushed a commit
that referenced
this pull request
Nov 3, 2020
Add test pattern to setImmediate when ref's type is not boolean PR-URL: #35852 Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test pattern to setImmediate when ref's type is not boolean
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes