Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: do not run GitHub actions for draft PRs #35910

Closed
wants to merge 1 commit into from
Closed

build: do not run GitHub actions for draft PRs #35910

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Nov 1, 2020

Closes: #35899

I also pushed another branch just to verify that this doesn't prevent branch pushes to execute the workflow: https://github.com/nodejs/node/commits/no-draft-workflow-with-branch

Opened as a draft this time.

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Nov 1, 2020
@targos
Copy link
Member Author

targos commented Nov 1, 2020

So, the condition works. Jobs were skipped:
image

@targos targos marked this pull request as ready for review November 1, 2020 09:38
@targos
Copy link
Member Author

targos commented Nov 1, 2020

Marking the PR a s ready is not enough to re-run the workflows.

@targos
Copy link
Member Author

targos commented Nov 1, 2020

image

Apparently GitHub thinks I'm from the future 😄

@gengjiawen
Copy link
Member

When we mark it as ready, will it trigger github action run ?

@Trott
Copy link
Member

Trott commented Nov 1, 2020

When we mark it as ready, will it trigger github action run ?

No, but I think we can manually run the jobs (and GitHub Actions are advisory in most cases anyway), so I'm OK with this behavior.

I'm going to try to manually kick off the jobs to confirm that's possible. Hopefully I'm not messing up @targos's experiment....

@Trott
Copy link
Member

Trott commented Nov 1, 2020

When we mark it as ready, will it trigger github action run ?

No, but I think we can manually run the jobs (and GitHub Actions are advisory in most cases anyway), so I'm OK with this behavior.

I'm going to try to manually kick off the jobs to confirm that's possible. Hopefully I'm not messing up @targos's experiment....

Argh, nope, it skips them still. I guess we'd have to kick off Jenkins for any PR opened as Draft? I'm still OK with that, although there are jobs in GitHub Actions (ASAN, tarball building, coverage, codeowners assignment, maybe others) that don't get run in Jenkins..... so it's less ideal, for sure....

@Trott
Copy link
Member

Trott commented Nov 1, 2020

image

Apparently GitHub thinks I'm from the future 😄

Hmmm... just in case the not-able-to-run-once-out-of-draft-mode stuff is all due to some daylight-savings-in-North-America weirdness, I'm going to put it into Draft mode again, and then take it out again....

@Trott Trott marked this pull request as draft November 1, 2020 14:48
@Trott Trott marked this pull request as ready for review November 1, 2020 14:49
@Trott
Copy link
Member

Trott commented Nov 1, 2020

Maybe pushing (or force-pushing) will be enough to kick off the jobs?

@Trott
Copy link
Member

Trott commented Nov 1, 2020

Rebasing against master and force-pushing to see if that kicks off the jobs.

@Trott
Copy link
Member

Trott commented Nov 1, 2020

That seems to have worked. I can live with that.

@gengjiawen
Copy link
Member

That seems to have worked. I can live with that.

Works with me too. Can this be integrated with our CI robot ?

@jasnell
Copy link
Member

jasnell commented Dec 16, 2020

Needs a rebase before this can land

targos added a commit that referenced this pull request Dec 21, 2020
@targos
build: do not run GitHub actions for draft PRs
aadb0bd 
PR-URL: #35910
Fixes: #35899
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@targos
Copy link
Member Author

targos commented Dec 21, 2020

Landed in aadb0bd

@targos targos closed this Dec 21, 2020
@targos targos deleted the no-draft-workflow branch December 21, 2020 14:34
targos added a commit that referenced this pull request Dec 21, 2020
@targos
build: do not run GitHub actions for draft PRs
82a2626 
PR-URL: #35910
Fixes: #35899
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@targos targos mentioned this pull request Dec 22, 2020
Merged
@richardlau richardlau mentioned this pull request Dec 23, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@watilde watilde watilde approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable Github CI for draft PRs with label
9 participants
@targos @gengjiawen @Trott @jasnell @benjamingr @lpinca @watilde @cjihrig @nodejs-github-bot