-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add coverage for uncovered if statement in fs.read function(callback and promise api) #35918
test: add coverage for uncovered if statement in fs.read function(callback and promise api) #35918
Conversation
Welcome @iammack and thanks for the pull request. Is this the line you're adding coverage for? https://coverage.nodejs.org/coverage-09af8c822c8e931b/lib/fs.js.html#L514 If so, we probably also want to test that it works when |
Glad to be contributing:) Yes, that line and this line: https://coverage.nodejs.org/coverage-642f2064c06793b7/lib/internal/fs/promises.js.html#L326. Actually, the test when |
Not sure what's the equivalent of "bringing this to the top of your inbox" in GitHub :p. So gentle ping @Trott |
I'm surprised that setting |
852a036
to
d7176d4
Compare
This comment has been minimized.
This comment has been minimized.
d7176d4
to
0027aca
Compare
Landed in 0027aca |
added test for uncovered if statement in lib/fs.js PR-URL: #35918 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
added test for uncovered if statement in lib/fs.js PR-URL: #35918 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
added test for uncovered if statement in lib/fs.js PR-URL: #35918 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
added test for uncovered if statement in lib/fs.js PR-URL: #35918 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
added test for uncovered if statement in lib/fs.js PR-URL: #35918 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Expanded coverage of tests as my first contribution to nodejs:). It would be really helpful if other contributors can point out any errors I have made and/or good practices I am missing!.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes