Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: fix comment in ByteSource #35972

Closed
wants to merge 1 commit into from
Closed

crypto: fix comment in ByteSource #35972

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Nov 4, 2020

allocated_data_ must not be a nullptr if size_ > 0.

Refs: #35821

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@tniessen tniessen requested a review from jasnell November 4, 2020 23:14
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/quic

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 4, 2020
@rickyes rickyes added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 5, 2020
@tniessen
Copy link
Member Author

tniessen commented Nov 5, 2020

Feel free to approve fast-tracking by adding 👍 on this comment.

@tniessen tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 5, 2020
@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 5, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 5, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34081/

lpinca pushed a commit that referenced this pull request Nov 5, 2020
@tniessen @lpinca
crypto: fix comment in ByteSource
c9e3848 
PR-URL: #35972
Refs: #35821
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@lpinca
Copy link
Member

lpinca commented Nov 5, 2020

Landed in c9e3848.

@lpinca lpinca closed this Nov 5, 2020
danielleadams pushed a commit that referenced this pull request Nov 9, 2020
@tniessen @danielleadams
crypto: fix comment in ByteSource
dc4936b 
PR-URL: #35972
Refs: #35821
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Nov 9, 2020
Merged
@tniessen tniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickyes rickyes rickyes approved these changes

@himself65 himself65 himself65 approved these changes

@devnexen devnexen devnexen approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@danbev danbev danbev approved these changes

@jasnell jasnell Awaiting requested review from jasnell

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.