Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: replace finally with PromisePrototypeFinally #35995

Closed
wants to merge 1 commit into from
Closed

fs: replace finally with PromisePrototypeFinally #35995

wants to merge 1 commit into from

Conversation

baruchiro
Copy link
Contributor

@baruchiro baruchiro commented Nov 6, 2020 •
edited
Loading

See suggestion here- #35993 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the fs Issues and PRs related to the fs subsystem / file system. label Nov 6, 2020
@baruchiro baruchiro mentioned this pull request Nov 6, 2020
Closed
@aduh95
Copy link
Contributor

aduh95 commented Nov 6, 2020

If you could change other .finally calls in this file as well, that'd be nice.

@baruchiro
Copy link
Contributor Author

Sorry for the force push, I following the commit guidelines now (I hope)

@baruchiro baruchiro changed the title Suggested refactor by #35993 fs: replace finally with PromisePrototypeFinally Nov 7, 2020
@aduh95
Copy link
Contributor

aduh95 commented Nov 7, 2020

@baruchiro Can you rebase to resolve the conflict please?

git fetch upstream master
git rebase upstream/master -i

@baruchiro
Copy link
Contributor Author

About initializing the workspace and running vcbuild test, I found a bug in the vcbuild.bat file related to *Visual Studio 19 Preview`, I have one fix for that (but it not solving the whole process).

Where should I open a bug and/or PR for that?

(PR will be here, of course... But should I open an issue first? Do I need to open the issue in the current repo, even if it not related to node itself, but to the repo itself?)

@aduh95
Copy link
Contributor

aduh95 commented Nov 8, 2020

Where should I open a bug and/or PR for that?

If you have a fix, PR is very welcome. Issue is not necessary if your PR describes the problem and the solution.

@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 8, 2020
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 8, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 8, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 8, 2020 •
edited by aduh95
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/34203/ ✅

@baruchiro
Copy link
Contributor Author

@benjamingr As first-time contributor I allow myself to ask "what now?"

When this PR will be merged?
Do I need to do something?

@aduh95
Copy link
Contributor

aduh95 commented Nov 9, 2020

@baruchiro Your PR is author ready, that means you don't have anything left to do :) You just have to wait for someone landing it for you on master. You can read more about what's the process here: https://github.com/nodejs/node/blob/master/doc/guides/collaborator-guide.md#accepting-modifications

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 9, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 9, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2020

Landed in 36fbbe0...a8b9ede

@github-actions github-actions bot closed this Nov 9, 2020
nodejs-github-bot pushed a commit that referenced this pull request Nov 9, 2020
@baruchiro @nodejs-github-bot
fs: replace finally with PromisePrototypeFinally
a8b9ede 
#35993 (comment)

PR-URL: #35995
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@baruchiro
Copy link
Contributor Author

@aduh95 So it actually taked my commits into master, but not by the Github PR interface?

Interesting technique 😀

@aduh95
Copy link
Contributor

aduh95 commented Nov 9, 2020

@baruchiro yes, the reasons are outlined here: https://github.com/nodejs/node/blob/master/doc/guides/collaborator-guide.md#landing-pull-requests

But anyway, you are now officially a Node.js contributor, congrats 🎉

@baruchiro baruchiro deleted the patch-1 branch November 9, 2020 19:15
@baruchiro
Copy link
Contributor Author

Hooray!! 🥇

But now I can't write that in my CV, because I don't know how to answer the question "What you did as a Node.js contributor?"... 😉😉

Never mind, I'm sure the next contribution I will understand more. I just need to find the next one.

@benjamingr
Copy link
Member

Feel free to ping me on Facebook for more contribution ideas :)

danielleadams pushed a commit that referenced this pull request Nov 10, 2020
@baruchiro @danielleadams
fs: replace finally with PromisePrototypeFinally
7ef9c70 
#35993 (comment)

PR-URL: #35995
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request Nov 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 9, 2020
@baruchiro @BethGriggs
fs: replace finally with PromisePrototypeFinally
1ed0a03 
#35993 (comment)

PR-URL: #35995
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@baruchiro @BethGriggs
fs: replace finally with PromisePrototypeFinally
affa710 
#35993 (comment)

PR-URL: #35995
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@baruchiro @BethGriggs
fs: replace finally with PromisePrototypeFinally
7c3b6f1 
#35993 (comment)

PR-URL: #35995
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr left review comments

@aduh95 aduh95 aduh95 approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@baruchiro @aduh95 @nodejs-github-bot @benjamingr @Trott