Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix added: info for stream._construct() #36067

Closed
wants to merge 1 commit into from
Closed

doc: fix added: info for stream._construct() #36067

wants to merge 1 commit into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Nov 10, 2020

readable._construct() and writable._construct() were added to
Node.js v15.0.0 via fb8cc72.

Fixes: #36058

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Nov 10, 2020
@lpinca
doc: fix added: info for stream._construct()
fa94436 
`readable._construct()` and `writable._construct()` were added to
Node.js v15.0.0 via fb8cc72.

Fixes: nodejs#36058
@lpinca lpinca force-pushed the fix/added-version-for-construct branch from 9da8acf to fa94436 Compare November 10, 2020 14:52
@lpinca lpinca changed the title doc: fix added: info for stream._construct() doc: fix added: info for stream._construct() Nov 10, 2020
a0viedo
a0viedo approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@a0viedo a0viedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduh95
Copy link
Contributor

aduh95 commented Nov 10, 2020

fast-track?

@aduh95 aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 10, 2020
@aduh95 aduh95 requested a review from ronag November 10, 2020 17:31
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 10, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 10, 2020
@github-actions
Copy link
Contributor

Landed in 60a97c0...0dee498

@github-actions github-actions bot closed this Nov 10, 2020
nodejs-github-bot pushed a commit that referenced this pull request Nov 10, 2020
@lpinca @nodejs-github-bot
doc: fix added: info for stream._construct()
0dee498 
`readable._construct()` and `writable._construct()` were added to
Node.js v15.0.0 via fb8cc72.

Fixes: #36058

PR-URL: #36067
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@lpinca lpinca deleted the fix/added-version-for-construct branch November 10, 2020 20:16
@targos
Copy link
Member

targos commented Nov 14, 2020

If the methods do not exist in v14.x, the doc is wrong on that branch: https://github.com/nodejs/node/blob/v14.x/doc/api/stream.md#readable_constructcallback
https://github.com/nodejs/node/blob/v14.x/doc/api/stream.md#writable_constructcallback

@lpinca lpinca mentioned this pull request Nov 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@ronag ronag ronag approved these changes

@a0viedo a0viedo a0viedo approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Streams: readable stream does not get _construct called
7 participants
@lpinca @aduh95 @targos @benjamingr @a0viedo @ronag @nodejs-github-bot