doc: cleanup events docs #36100
Closed
doc: cleanup events docs #36100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
events
benjamingr
approved these changes
Nov 12, 2020
|
@nodejs/events @nodejs/documentation |
Trott
approved these changes
Nov 13, 2020
aymen94
approved these changes
Nov 15, 2020
|
LGTM |
aduh95
reviewed
Nov 17, 2020
Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell
force-pushed
the
cleanup-events-docs
branch
from
26abaa7
to
3b6f6e1
Compare
jasnell
added
the
author ready
jasnell
added a commit
that referenced
this pull request
Nov 23, 2020
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #36100 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
|
Landed in abe3456 |
|
@jasnell any chance you can land the graduate EventTarget/AbortController PR next? |
|
In the process of doing so. Running one final ci after rebasing |
danielleadams
pushed a commit
that referenced
this pull request
Dec 7, 2020
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #36100 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
May 30, 2021
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #36100 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 31, 2021
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #36100 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #36100 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #36100 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #36100 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #36001 which must land first, and addresses a concern
over the documentation structure raised in the review of #36001.
The first commit is from #36001
/cc @Trott
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes