-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http2: add support for TypedArray to getUnpackedSettings #36141
Closed
aduh95
wants to merge
3
commits into
nodejs:master
from
aduh95:http2-getUnpackedSettings-ArrayBufferView
Closed
http2: add support for TypedArray to getUnpackedSettings #36141
aduh95
wants to merge
3
commits into
nodejs:master
from
aduh95:http2-getUnpackedSettings-ArrayBufferView
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
nodejs-github-bot
added
buffer
Issues and PRs related to the buffer subsystem.
http2
Issues or PRs related to the http2 subsystem.
labels
Nov 16, 2020
mcollina
approved these changes
Nov 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
aduh95
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Nov 17, 2020
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Nov 17, 2020
This comment has been minimized.
This comment has been minimized.
jasnell
approved these changes
Nov 17, 2020
This comment has been minimized.
This comment has been minimized.
Trott
approved these changes
Nov 18, 2020
aduh95
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Nov 19, 2020
github-actions
bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Nov 19, 2020
Landed in 275aa68...ad0a01c |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Nov 19, 2020
PR-URL: #36141 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Nov 22, 2020
PR-URL: #36141 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
May 16, 2021
PR-URL: #36141 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
PR-URL: #36141 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
buffer
Issues and PRs related to the buffer subsystem.
http2
Issues or PRs related to the http2 subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is trying to fix the behaviour of
http2.getUnpackedSettings
.The error message says we can use
TypedArray
, the documentation says we can useUint8Array
, but in practice only Node.jsBuffer
object are accepted.This PR adds support for all
TypedArray
and removeDataView
from the error message. It also updates the documentation.Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes