Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark,child_process: remove failing benchmark parameter #36295

Closed
wants to merge 1 commit into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 27, 2020

A 16 MiB strings seems to be too large to be send to the parent process,
making the whole benchmark throws.

See https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/717/console

Trial and error taught me that 65536 << 6 - 1 is the largest values acceptable to not make the benchmark throw. That's maybe a bug we want to fix, but until someone sends a fix, this PR allows child_process benchmark suite to be run to completion.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

A 16 MiB strings seems to be too large to be send to the parent process,
making the whole benchmark throws.
@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. child_process Issues and PRs related to the child_process subsystem. labels Nov 27, 2020
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 30, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 30, 2020
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 30, 2020

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 2, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 2, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2020

Landed in 187a862...99f6167

@github-actions github-actions bot closed this Dec 2, 2020
nodejs-github-bot pushed a commit that referenced this pull request Dec 2, 2020
A 16 MiB strings seems to be too large to be send to the parent process,
making the whole benchmark throws.

PR-URL: #36295
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95 aduh95 deleted the fix-child_process-benchmark branch December 2, 2020 20:34
danielleadams pushed a commit that referenced this pull request Dec 7, 2020
A 16 MiB strings seems to be too large to be send to the parent process,
making the whole benchmark throws.

PR-URL: #36295
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Dec 7, 2020
cjihrig pushed a commit to cjihrig/node that referenced this pull request Dec 8, 2020
A 16 MiB strings seems to be too large to be send to the parent process,
making the whole benchmark throws.

PR-URL: nodejs#36295
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request May 1, 2021
A 16 MiB strings seems to be too large to be send to the parent process,
making the whole benchmark throws.

PR-URL: #36295
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. benchmark Issues and PRs related to the benchmark subsystem. child_process Issues and PRs related to the child_process subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants