-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: revised the link about the Collaborators discussion page
#36335
docs: revised the link about the Collaborators discussion page
#36335
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current link is correct. This change uses a link to the Node.js repo discussion page which is different.
I'm going to close this, but feel free to comment or re-open if you think that's hasty of me. |
The current link leads to a 404 page. That's why I revised it. You can try to open the link. I have tried before. |
It seems that I have no qualification to re-open this pull request. |
Is it a 404 or a 403? If 404, that's unfortunate and (IMO, at least) a GitHub bug. You need to have permissions to open it. It's restricted to members of |
It's a 404 and I don't think GitHub would consider it a bug. Many URLs return 404 when you don't have the permissions to view them. I believe it is to hide the fact that the URL is valid. |
09e1b03
to
cb023a3
Compare
Yeah, I'm aware of that practice. It just seems like an odd thing to choose to hide in this case and in my opinion. Ergo: Bug in my opinion. But my opinion is not as informed as the folks at GitHub so there's a high likelihood I'm just straight up wrong. 😀 |
Revised the link about the
Collaborators discussion page
.Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes