Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: revised the link about the Collaborators discussion page #36335

Conversation

iam-frankqiu
Copy link
Contributor

Revised the link about the Collaborators discussion page.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Dec 1, 2020
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current link is correct. This change uses a link to the Node.js repo discussion page which is different.

@Trott
Copy link
Member

Trott commented Dec 2, 2020

I'm going to close this, but feel free to comment or re-open if you think that's hasty of me.

@Trott Trott closed this Dec 2, 2020
@iam-frankqiu
Copy link
Contributor Author

Current link is correct. This change uses a link to the Node.js repo discussion page which is different.

The current link leads to a 404 page. That's why I revised it. You can try to open the link. I have tried before.

@iam-frankqiu
Copy link
Contributor Author

I'm going to close this, but feel free to comment or re-open if you think that's hasty of me.

I'm going to close this, but feel free to comment or re-open if you think that's hasty of me.

It seems that I have no qualification to re-open this pull request.

@Trott Trott reopened this Dec 6, 2020
@Trott
Copy link
Member

Trott commented Dec 6, 2020

The current link leads to a 404 page. That's why I revised it. You can try to open the link. I have tried before.

Is it a 404 or a 403? If 404, that's unfortunate and (IMO, at least) a GitHub bug. You need to have permissions to open it. It's restricted to members of @nodejs/collaborators, I believe. This is a public document, so that should be mentioned in the text to avoid this kind of confusion. So maybe that can be the change this PR implements?

@targos
Copy link
Member

targos commented Dec 6, 2020

It's a 404 and I don't think GitHub would consider it a bug. Many URLs return 404 when you don't have the permissions to view them. I believe it is to hide the fact that the URL is valid.

@Trott
Copy link
Member

Trott commented Dec 9, 2020

It's a 404 and I don't think GitHub would consider it a bug. Many URLs return 404 when you don't have the permissions to view them. I believe it is to hide the fact that the URL is valid.

Yeah, I'm aware of that practice. It just seems like an odd thing to choose to hide in this case and in my opinion. Ergo: Bug in my opinion. But my opinion is not as informed as the folks at GitHub so there's a high likelihood I'm just straight up wrong. 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants