Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm: add SafeForTerminationScopes for SIGINT interruptions #36344

Closed
wants to merge 2 commits into from

Commits on Dec 1, 2020

  1. vm: add SafeForTerminationScopes for SIGINT interruptions

    Some embedders, like Electron, choose to start Node.js with
    `only_terminate_in_safe_scope` set to `true`. In those cases, parts
    of the API that expect execution termination to happen need to
    be marked as able to receive those events. In our case, this is
    the Ctrl+C support of the `vm` module (and Workers, but since
    we’re in control of creating the `Isolate` for them, that’s a
    non-concern there).
    
    Add those scopes and add a regression test.
    addaleax committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    7449ba3 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2020

  1. Configuration menu
    Copy the full SHA
    8bb62dc View commit details
    Browse the repository at this point in the history