[v12.x backport] v8: implement v8.takeCoverage() and v8.stopCoverage() #36352
Conversation
nodejs-github-bot
added
c++
|
/cc @joyeecheung |
rickyes
added
semver-minor
github-actions
bot
removed
the
request-ci
|
@Trott I'm not sure what the back-porting process entails, perhaps you could give a hand here? |
Because 12.x is LTS, I believe only people in @nodejs/releasers should land these kinds of PRs. 12.x is Maintenance and so I think semver-minor PRs like this one typically don't land there, but I could be wrong. So they may need you or someone else to make the case for landing it. |
|
12.x is now in maintenance and we are unlikely to do another semver minor release |
|
Maybe we can make another semver minor release？ @nodejs/releasers may have to ask for your help. |
This PR was proposed when it's still at the LTS phase, but has been waiting for the Review to land and it is no longer LTS. |
richardlau
force-pushed
the
v12.x-staging
branch
from
0692611
to
6cef0e3
Compare
Add an v8.takeCoverage() API that allows the user to write the coverage started by NODE_V8_COVERAGE to disk on demand. The coverage can be written multiple times during the lifetime of the process, each time the execution counter will be reset. When the process is about to exit, one last coverage will still be written to disk. Also refactors the internal profiler connection code so that we use the inspector response id to identify the profile response instead of using an ad-hoc flag in C++. PR-URL: nodejs#33807 Backport-PR-URL: nodejs#36352 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ben Coe <bencoe@gmail.com>
Add a v8.stopCoverage() API to stop the coverage collection started by NODE_V8_COVERAGE - this would be useful in conjunction with v8.takeCoverage() if the user don't want to emit the coverage at the process exit but still want to collect it on demand at some point. PR-URL: nodejs#33807 Backport-PR-URL: nodejs#36352 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ben Coe <bencoe@gmail.com>
richardlau
force-pushed
the
backport-33807-to-v12.x
branch
from
2d36fe4
to
86f34ee
Compare
|
Landed in d7a4ccd...86f34ee |
Checklist
PR-URL: #33807
Reviewed-By: @gengjiawen
Reviewed-By: @bcoe
Reviewed-By: @bnoordhuis
Reviewed-By: @addaleax
make -j4 test(UNIX), orvcbuild test(Windows) passes